Minor tweaks to pre/inline style for inline comments in HTML mail

Summary:
Ref T10694.

  - Shift margins/padding around so inlines with multiple paragraphs get reasonable spacing.
  - Add `text-decoration: none` to the "View Inline" link to kill the underline.

Test Plan: {F1265342}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10694

Differential Revision: https://secure.phabricator.com/D15863

src/applications/differential/editor/DifferentialTransactionEditor.php

@@ -1385,7 +1385,17 @@ final class DifferentialTransactionEditor
     $header = pht('INLINE COMMENTS');
 
     $section_text = "\n".$section->getPlaintext();
-    $section_html = $section->getHTML();
+
+    $style = array(
+      'margin: 12px 0;',
+    );
+
+    $section_html = phutil_tag(
+      'div',
+      array(
+        'style' => implode(' ', $style),
+      ),
+      $section->getHTML());
 
     $body->addPlaintextSection($header, $section_text, false);
     $body->addHTMLSection($header, $section_html);

src/applications/differential/mail/DifferentialInlineCommentMailView.php

@@ -201,7 +201,8 @@ final class DifferentialInlineCommentMailView
 
     if ($is_html) {
       $style = array(
-        'padding: 8px 12px;',
+        'margin: 8px 0;',
+        'padding: 0 12px;',
       );
 
       if ($is_quote) {
@@ -249,7 +250,7 @@ final class DifferentialInlineCommentMailView
     }
 
     $attributes = array(
-      'style' => 'padding: 0; margin: 0;',
+      'style' => 'padding: 0; margin: 8px;',
     );
 
     $engine = PhabricatorMarkupEngine::newMarkupEngine(array())
@@ -461,6 +462,7 @@ final class DifferentialInlineCommentMailView
       if ($link_href) {
         $link_style = array(
           'float: right;',
+          'text-decoration: none;',
         );
 
         $link = phutil_tag(
@@ -477,7 +479,7 @@ final class DifferentialInlineCommentMailView
       $style = array(
         'color: #74777d;',
         'background: #eff2f4;',
-        'padding: 4px 8px;',
+        'padding: 6px 8px;',
         'overflow: hidden;',
       );