revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-10 08:52:39 +01:00
Code Issues Releases Wiki Activity

Don't explicitly name abstract base classes

Browse source 
Summary: Ref T5655. It is superfluous to include "base" in the name of an abstract base class. Furthermore, it is not done consistently within the code base.

Test Plan: Ran `arc unit`.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: epriestley, Korvin

Maniphest Tasks: T5655

Differential Revision: https://secure.phabricator.com/D9989
This commit is contained in:
Joshua Spence 2014-07-22 00:05:17 +10:00
parent 76ed7d1a02
commit 37106c1b31
6 changed files with 11 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/__phutil_library_map__.php
View file

@ -1835,7 +1835,7 @@ phutil_register_library_map(array(
'PhabricatorNotificationTestController' => 'applications/notification/controller/PhabricatorNotificationTestController.php',
'PhabricatorOAuthClientAuthorization' => 'applications/oauthserver/storage/PhabricatorOAuthClientAuthorization.php',
'PhabricatorOAuthClientAuthorizationQuery' => 'applications/oauthserver/query/PhabricatorOAuthClientAuthorizationQuery.php',
'PhabricatorOAuthClientBaseController' => 'applications/oauthserver/controller/client/PhabricatorOAuthClientBaseController.php',
'PhabricatorOAuthClientController' => 'applications/oauthserver/controller/client/PhabricatorOAuthClientController.php',
'PhabricatorOAuthClientDeleteController' => 'applications/oauthserver/controller/client/PhabricatorOAuthClientDeleteController.php',
'PhabricatorOAuthClientEditController' => 'applications/oauthserver/controller/client/PhabricatorOAuthClientEditController.php',
'PhabricatorOAuthClientListController' => 'applications/oauthserver/controller/client/PhabricatorOAuthClientListController.php',
@ -4644,11 +4644,11 @@ phutil_register_library_map(array(
'PhabricatorPolicyInterface',
),
'PhabricatorOAuthClientAuthorizationQuery' => 'PhabricatorCursorPagedPolicyAwareQuery',
'PhabricatorOAuthClientBaseController' => 'PhabricatorOAuthServerController',
'PhabricatorOAuthClientDeleteController' => 'PhabricatorOAuthClientBaseController',
'PhabricatorOAuthClientEditController' => 'PhabricatorOAuthClientBaseController',
'PhabricatorOAuthClientListController' => 'PhabricatorOAuthClientBaseController',
'PhabricatorOAuthClientViewController' => 'PhabricatorOAuthClientBaseController',
'PhabricatorOAuthClientController' => 'PhabricatorOAuthServerController',
'PhabricatorOAuthClientDeleteController' => 'PhabricatorOAuthClientController',
'PhabricatorOAuthClientEditController' => 'PhabricatorOAuthClientController',
'PhabricatorOAuthClientListController' => 'PhabricatorOAuthClientController',
'PhabricatorOAuthClientViewController' => 'PhabricatorOAuthClientController',
'PhabricatorOAuthResponse' => 'AphrontResponse',
'PhabricatorOAuthServerAccessToken' => 'PhabricatorOAuthServerDAO',
'PhabricatorOAuthServerAuthController' => 'PhabricatorAuthController',

2
src/applications/oauthserver/controller/client/PhabricatorOAuthClientBaseController.php → src/applications/oauthserver/controller/client/PhabricatorOAuthClientController.php
View file

@ -1,6 +1,6 @@
<?php
abstract class PhabricatorOAuthClientBaseController
abstract class PhabricatorOAuthClientController
extends PhabricatorOAuthServerController {
private $clientPHID;

2
src/applications/oauthserver/controller/client/PhabricatorOAuthClientDeleteController.php
View file

@ -1,7 +1,7 @@
<?php
final class PhabricatorOAuthClientDeleteController
extends PhabricatorOAuthClientBaseController {
extends PhabricatorOAuthClientController {
public function processRequest() {
$request = $this->getRequest();

2
src/applications/oauthserver/controller/client/PhabricatorOAuthClientEditController.php
View file

@ -1,7 +1,7 @@
<?php
final class PhabricatorOAuthClientEditController
extends PhabricatorOAuthClientBaseController {
extends PhabricatorOAuthClientController {
public function processRequest() {
$request = $this->getRequest();

2
src/applications/oauthserver/controller/client/PhabricatorOAuthClientListController.php
View file

@ -1,7 +1,7 @@
<?php
final class PhabricatorOAuthClientListController
extends PhabricatorOAuthClientBaseController {
extends PhabricatorOAuthClientController {
private $queryKey;

2
src/applications/oauthserver/controller/client/PhabricatorOAuthClientViewController.php
View file

@ -1,7 +1,7 @@
<?php
final class PhabricatorOAuthClientViewController
extends PhabricatorOAuthClientBaseController {
extends PhabricatorOAuthClientController {
public function processRequest() {
$request = $this->getRequest();