From 37489865d4bb4681aba87f582c9800b608c5c553 Mon Sep 17 00:00:00 2001 From: Chad Little Date: Mon, 14 Aug 2017 18:58:25 +0000 Subject: [PATCH] Remove "File Name" search tool Summary: Removing this cleanly in event we want to put it back later. 99% of these cases are likely workable either by command line or the typeahead. Will gauge feedback if users notice. Test Plan: Reload page, perform file grep search. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D18425 --- .../controller/DiffusionBrowseController.php | 25 ------------------- 1 file changed, 25 deletions(-) diff --git a/src/applications/diffusion/controller/DiffusionBrowseController.php b/src/applications/diffusion/controller/DiffusionBrowseController.php index 63dc6c3c86..d1800bc771 100644 --- a/src/applications/diffusion/controller/DiffusionBrowseController.php +++ b/src/applications/diffusion/controller/DiffusionBrowseController.php @@ -449,18 +449,6 @@ final class DiffusionBrowseController extends DiffusionController { 'limit' => $pager->getPageSize() + 1, 'offset' => $pager->getOffset(), )); - } else { // Filename search. - $search_mode = 'find'; - $query_string = $request->getStr('find'); - $results = $this->callConduitWithDiffusionRequest( - 'diffusion.querypaths', - array( - 'pattern' => $query_string, - 'commit' => $drequest->getStableCommit(), - 'path' => $drequest->getPath(), - 'limit' => $pager->getPageSize() + 1, - 'offset' => $pager->getOffset(), - )); } break; } @@ -472,12 +460,6 @@ final class DiffusionBrowseController extends DiffusionController { 'File content matching "%s" under "%s"', $query_string, nonempty($drequest->getPath(), '/')); - } else { - $table = $this->renderFindResults($results); - $header = pht( - 'Paths matching "%s" under "%s"', - $query_string, - nonempty($drequest->getPath(), '/')); } return id(new PHUIObjectBoxView()) @@ -1595,13 +1577,6 @@ final class DiffusionBrowseController extends DiffusionController { ->appendChild(pht('Search is not available in Subversion.')); break; default: - $forms[] = id(clone $form) - ->appendChild( - id(new AphrontFormTextWithSubmitControl()) - ->setLabel(pht('File Name')) - ->setSubmitLabel(pht('Search File Names')) - ->setName('find') - ->setValue($this->getRequest()->getStr('find'))); $forms[] = id(clone $form) ->appendChild( id(new AphrontFormTextWithSubmitControl())