Remove various additional calls to getCallsign()

Summary: Ref T4245. These are all straightforward to remove.

Test Plan:
- Edited paths in a package.
- Ran `bin/audit delete --repositories ...` with various identifiers.
- Searched by repository for `R3`, `rAAAA` in Harbormaster.
- Did a Herald dry run on a commit.
- Browsed commits, made comments.
- Viewed a Releeph product list.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T4245

Differential Revision: https://secure.phabricator.com/D14927

src/applications/audit/editor/PhabricatorAuditCommentEditor.php

@@ -46,7 +46,7 @@ final class PhabricatorAuditCommentEditor extends PhabricatorEditor {
       'diffusion-audit-'.$commit->getPHID(),
       pht(
         'Commit %s',
-        'r'.$repository->getCallsign().$commit->getCommitIdentifier()),
+        $commit->getMonogram()),
     );
   }
 

src/applications/audit/management/PhabricatorAuditManagementDeleteWorkflow.php

@@ -222,22 +222,23 @@ final class PhabricatorAuditManagementDeleteWorkflow
     return $list;
   }
 
-  private function loadRepos($callsigns) {
+  private function loadRepos($identifiers) {
-    $callsigns = $this->parseList($callsigns);
+    $identifiers = $this->parseList($identifiers);
-    if (!$callsigns) {
+    if (!$identifiers) {
       return null;
     }
 
-    $repos = id(new PhabricatorRepositoryQuery())
+    $query = id(new PhabricatorRepositoryQuery())
       ->setViewer($this->getViewer())
-      ->withCallsigns($callsigns)
+      ->withIdentifiers($identifiers);
-      ->execute();
-    $repos = mpull($repos, null, 'getCallsign');
 
-    foreach ($callsigns as $sign) {
+    $repos = $query->execute();
-      if (empty($repos[$sign])) {
+
+    $map = $query->getIdentifierMap();
+    foreach ($identifiers as $identifier) {
+      if (empty($map[$identifier])) {
         throw new PhutilArgumentUsageException(
-          pht('No such repository with callsign "%s"!', $sign));
+          pht('No repository "%s" exists!', $identifier));
       }
     }
 

src/applications/diffusion/herald/HeraldCommitAdapter.php

@@ -130,10 +130,7 @@ final class HeraldCommitAdapter
   }
 
   public function getHeraldName() {
-    return
+    return $this->commit->getMonogram();
-      'r'.
-      $this->repository->getCallsign().
-      $this->commit->getCommitIdentifier();
   }
 
   public function loadAffectedPaths() {

src/applications/harbormaster/query/HarbormasterBuildableSearchEngine.php

@@ -112,7 +112,7 @@ final class HarbormasterBuildableSearchEngine
         } else if ($object instanceof DifferentialDiff) {
           $diff_names[] = $object->getID();
         } else if ($object instanceof PhabricatorRepository) {
-          $repository_names[] = 'r'.$object->getCallsign();
+          $repository_names[] = $object->getMonogram();
         } else if ($object instanceof PhabricatorRepositoryCommit) {
           $repository = $object->getRepository();
           $commit_names[] = $repository->formatCommitName(

src/applications/owners/controller/PhabricatorOwnersPathsController.php

@@ -83,7 +83,7 @@ final class PhabricatorOwnersPathsController
       }
     }
 
-    $repos = mpull($repos, 'getCallsign', 'getPHID');
+    $repos = mpull($repos, 'getMonogram', 'getPHID');
     asort($repos);
 
     $template = new AphrontTypeaheadTemplateView();

src/applications/releeph/controller/product/ReleephProductCreateController.php

@@ -121,11 +121,11 @@ final class ReleephProductCreateController extends ReleephProductController {
 
     foreach ($repos as $repo_id => $repo) {
       $repo_name = $repo->getName();
-      $callsign = $repo->getCallsign();
+      $display = $repo->getDisplayName();
-      $choices[$repo->getPHID()] = "r{$callsign} ({$repo_name})";
+      $choices[$repo->getPHID()] = "{$display} ({$repo_name})";
     }
 
-    ksort($choices);
+    asort($choices);
     return $choices;
   }
 

src/applications/releeph/differential/DifferentialReleephRequestFieldSpecification.php

@@ -372,7 +372,7 @@ final class DifferentialReleephRequestFieldSpecification extends Phobject {
             'part of a Releeph branch, but also has %d path change(s) not '.
             'part of a Releeph branch!',
             $commit->getCommitIdentifier(),
-            $repo->getCallsign(),
+            $repo->getDisplayName(),
             count($in_branch),
             count($ex_branch));
           phlog($error);

src/applications/releeph/query/ReleephProductSearchEngine.php

@@ -114,9 +114,9 @@ final class ReleephProductSearchEngine
         phutil_tag(
           'a',
           array(
-            'href' => '/diffusion/'.$repo->getCallsign().'/',
+            'href' => $repo->getURI(),
           ),
-          'r'.$repo->getCallsign()));
+          $repo->getMonogram()));
 
       $list->addItem($item);
     }