Support logged-out access to more Harbormaster controllers

Summary:
Fixes T13145. The list controllers properly support public access already, but some of the view/detail controllers did not.

Allow logged-out users to browse builds, buildables, plans, etc., provided they can see the corresponding objects.

Test Plan: As a logged-out user, browsed around builds, build plans, logs, etc., without hitting any login pages.

Reviewers: amckinley

Reviewed By: amckinley

Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam

Maniphest Tasks: T13145

Differential Revision: https://secure.phabricator.com/D19459

src/applications/harbormaster/controller/HarbormasterBuildLogDownloadController.php

@@ -3,6 +3,10 @@
 final class HarbormasterBuildLogDownloadController
   extends HarbormasterController {
 
+  public function shouldAllowPublic() {
+    return true;
+  }
+
   public function handleRequest(AphrontRequest $request) {
     $request = $this->getRequest();
     $viewer = $request->getUser();

src/applications/harbormaster/controller/HarbormasterBuildLogRenderController.php

@@ -3,6 +3,10 @@
 final class HarbormasterBuildLogRenderController
   extends HarbormasterController {
 
+  public function shouldAllowPublic() {
+    return true;
+  }
+
   public function handleRequest(AphrontRequest $request) {
     $viewer = $this->getViewer();
 

src/applications/harbormaster/controller/HarbormasterBuildLogViewController.php

@@ -3,6 +3,10 @@
 final class HarbormasterBuildLogViewController
   extends HarbormasterController {
 
+  public function shouldAllowPublic() {
+    return true;
+  }
+
   public function handleRequest(AphrontRequest $request) {
     $viewer = $this->getViewer();
 

src/applications/harbormaster/controller/HarbormasterBuildViewController.php

@@ -3,6 +3,10 @@
 final class HarbormasterBuildViewController
   extends HarbormasterController {
 
+  public function shouldAllowPublic() {
+    return true;
+  }
+
   public function handleRequest(AphrontRequest $request) {
     $request = $this->getRequest();
     $viewer = $request->getUser();

src/applications/harbormaster/controller/HarbormasterBuildableViewController.php

@@ -3,6 +3,10 @@
 final class HarbormasterBuildableViewController
   extends HarbormasterController {
 
+  public function shouldAllowPublic() {
+    return true;
+  }
+
   public function handleRequest(AphrontRequest $request) {
     $viewer = $this->getViewer();
 
@@ -350,6 +354,4 @@ final class HarbormasterBuildableViewController
     return array($lint, $unit);
   }
 
-
-
 }

src/applications/harbormaster/controller/HarbormasterLintMessagesController.php

@@ -3,6 +3,10 @@
 final class HarbormasterLintMessagesController
   extends HarbormasterController {
 
+  public function shouldAllowPublic() {
+    return true;
+  }
+
   public function handleRequest(AphrontRequest $request) {
     $viewer = $this->getViewer();
 

src/applications/harbormaster/controller/HarbormasterPlanViewController.php

@@ -2,6 +2,10 @@
 
 final class HarbormasterPlanViewController extends HarbormasterPlanController {
 
+  public function shouldAllowPublic() {
+    return true;
+  }
+
   public function handleRequest(AphrontRequest $request) {
     $viewer = $this->getViewer();
     $id = $request->getURIData('id');

src/applications/harbormaster/controller/HarbormasterStepViewController.php

@@ -3,6 +3,10 @@
 final class HarbormasterStepViewController
   extends HarbormasterPlanController {
 
+  public function shouldAllowPublic() {
+    return true;
+  }
+
   public function handleRequest(AphrontRequest $request) {
     $viewer = $this->getViewer();
     $id = $request->getURIData('id');

src/applications/harbormaster/controller/HarbormasterUnitMessageListController.php

@@ -3,6 +3,10 @@
 final class HarbormasterUnitMessageListController
   extends HarbormasterController {
 
+  public function shouldAllowPublic() {
+    return true;
+  }
+
   public function handleRequest(AphrontRequest $request) {
     $viewer = $this->getViewer();
 

src/applications/harbormaster/controller/HarbormasterUnitMessageViewController.php

@@ -3,6 +3,10 @@
 final class HarbormasterUnitMessageViewController
   extends HarbormasterController {
 
+  public function shouldAllowPublic() {
+    return true;
+  }
+
   public function handleRequest(AphrontRequest $request) {
     $viewer = $this->getViewer();