revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-20 12:30:56 +01:00
Code Issues Releases Wiki Activity

Fix an issue with mentioning revisions on the new EditEngine code

Browse source 
Summary:
Ref T12020. Ref T11114. If we continue here on a mention, we try to generate `$old`, which requires reviewers to be attached. They won't be for simple codepaths like mentions.

Instead, just bail early: we don't need to do anything anyway since we can't possibly find any more errors with zero transactions.

Test Plan: Mentioned a revision on a task.

Reviewers: chad, avivey

Reviewed By: avivey

Maniphest Tasks: T11114, T12020

Differential Revision: https://secure.phabricator.com/D17059
This commit is contained in:
epriestley 2016-12-14 14:00:25 -08:00
parent e077d2f7a7
commit 378387a078
1 changed files with 7 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/applications/differential/xaction/DifferentialRevisionReviewersTransaction.php
View file

@ -286,6 +286,13 @@ final class DifferentialRevisionReviewersTransaction
$actor = $this->getActor(); $actor = $this->getActor();
$errors = array(); $errors = array();
if (!$xactions) {
// If we aren't applying new reviewer transactions, just bail. We need
// reviewers to be attached to the revision continue validation, and
// they won't always be (for example, when mentioning a revision).
return $errors;
}
$author_phid = $object->getAuthorPHID(); $author_phid = $object->getAuthorPHID();
$config_self_accept_key = 'differential.allow-self-accept'; $config_self_accept_key = 'differential.allow-self-accept';
$allow_self_accept = PhabricatorEnv::getEnvConfig($config_self_accept_key); $allow_self_accept = PhabricatorEnv::getEnvConfig($config_self_accept_key);