Adding Phriction 'Document Index' link to the crumbs actions

Summary:
removed references to doc index from document controller / content display / whatever name it currently has

Refs T2686

Test Plan: saw it - touched it - tested it

Reviewers: epriestley, chad

Reviewed By: chad

CC: aran, Korvin

Maniphest Tasks: T2686

Differential Revision: https://secure.phabricator.com/D5342

Conflicts:

	src/applications/phriction/controller/PhrictionDocumentController.php

src/applications/phriction/controller/PhrictionController.php

@@ -49,6 +49,14 @@ abstract class PhrictionController extends PhabricatorController {
   public function buildApplicationCrumbs() {
     $crumbs = parent::buildApplicationCrumbs();
 
+    if (get_class($this) != 'PhrictionListController') {
+      $crumbs->addAction(
+        id(new PhabricatorMenuItemView())
+          ->setName(pht('Document Index'))
+          ->setHref('/phriction/')
+          ->setIcon('transcript'));
+    }
+
     $crumbs->addAction(
       id(new PhabricatorMenuItemView())
         ->setName(pht('Create Document'))

src/applications/phriction/controller/PhrictionDocumentController.php

@@ -132,13 +132,6 @@ final class PhrictionDocumentController
             $handles[$project_phid]->renderLink()));
       }
 
-      $index_link = phutil_tag(
-        'a',
-        array(
-          'href' => '/phriction/',
-        ),
-        pht('Document Index'));
-
       $subscriber_view = null;
       if ($subscribers) {
         $subcriber_list = array();
@@ -219,8 +212,7 @@ final class PhrictionDocumentController
       }
 
       $page_content = hsprintf(
-        '<div class="phriction-content">%s%s%s%s</div>',
-        $index_link,
+        '<div class="phriction-content">%s%s%s</div>',
         $byline,
         $move_notice,
         $core_content);