revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-23 14:00:56 +01:00
Code Issues Releases Wiki Activity

[Redesign] Make ObjectBox Header conditional

Browse source 
Summary: Ref T8099. In cases like dashboards, we don't always want a header with ObjectBox. This makes it optional.

Test Plan: Review a tab panel, see no weird lines.

Reviewers: btrahan, epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T8099

Differential Revision: https://secure.phabricator.com/D12920
This commit is contained in:
Chad Little 2015-05-19 06:39:15 -07:00
parent 1562dca214
commit 37cd1735d9
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/view/phui/PHUIObjectBoxView.php
View file

@ -159,10 +159,11 @@ final class PHUIObjectBoxView extends AphrontView {
$header_color = $this->headerColor; $header_color = $this->headerColor;
} }
$header = null;
if ($this->header) { if ($this->header) {
$header = $this->header; $header = $this->header;
$header->setHeaderColor($header_color); $header->setHeaderColor($header_color);
} else { } else if ($this->headerText) {
$header = id(new PHUIHeaderView()) $header = id(new PHUIHeaderView())
->setHeader($this->headerText) ->setHeader($this->headerText)
->setHeaderColor($header_color); ->setHeaderColor($header_color);