revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-02-01 01:18:22 +01:00
Code Issues Releases Wiki Activity

changed wordwrap call to utf8 hard wrap call in multiple places

Browse source 
Summary: using to phutil_utf8_hard_wrap instead of wordwrap

Test Plan: hard_wrap already unit tested

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D5155
This commit is contained in:
kwadwo 2013-02-28 09:17:58 -08:00 • committed by epriestley
parent 9891394e80
commit 37ee66e27f
3 changed files with 6 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/applications/maniphest/view/ManiphestTransactionDetailView.php
View file

@ -570,8 +570,8 @@ final class ManiphestTransactionDetailView extends ManiphestView {
case ManiphestTransactionType::TYPE_DESCRIPTION: case ManiphestTransactionType::TYPE_DESCRIPTION:
$id = $transaction->getID(); $id = $transaction->getID();
$old_text = wordwrap($transaction->getOldValue(), 80); $old_text = phutil_utf8_hard_wrap($transaction->getOldValue(), 80);
$new_text = wordwrap($transaction->getNewValue(), 80); $new_text = phutil_utf8_hard_wrap($transaction->getNewValue(), 80);
$engine = new PhabricatorDifferenceEngine(); $engine = new PhabricatorDifferenceEngine();
$changeset = $engine->generateChangesetFromFileContent($old_text, $changeset = $engine->generateChangesetFromFileContent($old_text,

4
src/applications/phriction/controller/PhrictionDiffController.php
View file

@ -48,8 +48,8 @@ final class PhrictionDiffController
$text_l = $content_l->getContent(); $text_l = $content_l->getContent();
$text_r = $content_r->getContent(); $text_r = $content_r->getContent();
$text_l = wordwrap($text_l, 80); $text_l = phutil_utf8_hard_wrap($text_l, 80);
$text_r = wordwrap($text_r, 80); $text_r = phutil_utf8_hard_wrap($text_r, 80);
$engine = new PhabricatorDifferenceEngine(); $engine = new PhabricatorDifferenceEngine();

6
src/applications/transactions/view/PhabricatorApplicationTransactionTextDiffDetailView.php
View file

@ -23,10 +23,8 @@ final class PhabricatorApplicationTransactionTextDiffDetailView
// TODO: On mobile, or perhaps by default, we should switch to 1-up once // TODO: On mobile, or perhaps by default, we should switch to 1-up once
// that is built. // that is built.
// TODO: This should be utf8-aware, but we don't currently have a plain-text $old = phutil_utf8_hard_wrap($old, 80);
// utf8 hard-wrap function. See T2554. $new = phutil_utf8_hard_wrap($new, 80);
$old = wordwrap($old, 80);
$new = wordwrap($new, 80);
$engine = new PhabricatorDifferenceEngine(); $engine = new PhabricatorDifferenceEngine();
$changeset = $engine->generateChangesetFromFileContent($old, $new); $changeset = $engine->generateChangesetFromFileContent($old, $new);