From 384244fa30484dde8737a7068e8ad3405e66c7c1 Mon Sep 17 00:00:00 2001 From: epriestley Date: Fri, 1 Feb 2013 08:46:28 -0800 Subject: [PATCH] Improve meme text outlining Summary: Fixed T2398 Test Plan: Ran a local test. It looked a tad better. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2398 Differential Revision: https://secure.phabricator.com/D4779 --- .../files/PhabricatorImageTransformer.php | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/applications/files/PhabricatorImageTransformer.php b/src/applications/files/PhabricatorImageTransformer.php index bdc96fdc77..a073d14030 100644 --- a/src/applications/files/PhabricatorImageTransformer.php +++ b/src/applications/files/PhabricatorImageTransformer.php @@ -180,9 +180,9 @@ final class PhabricatorImageTransformer { if (Filesystem::pathExists($font_root.'impact.ttf')) { $font_path = $font_root.'impact.ttf'; } - $white = imagecolorallocate($img, 255, 255, 255); - $black = imagecolorallocate($img, 0, 0, 0); - $border_width = 3; + $text_color = imagecolorallocate($img, 255, 255, 255); + $border_color = imagecolorallocatealpha($img, 0, 0, 0, 110); + $border_width = 4; $font_max = 200; $font_min = 5; for ($i = $font_max; $i > $font_min; $i--) { @@ -198,8 +198,8 @@ final class PhabricatorImageTransformer { $i, $x, $y, - $white, - $black, + $text_color, + $border_color, $border_width, $font_path, $upper_text); @@ -217,8 +217,8 @@ final class PhabricatorImageTransformer { $i, $x, $y, - $white, - $black, + $text_color, + $border_color, $border_width, $font_path, $lower_text);