revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-30 10:42:41 +01:00
Code Issues Releases Wiki Activity

[Redesign] Fix alignment of icon/grip on ObjectList

Browse source 
Summary:
Ref T8099, these should sit in a 4px gutter.

Also:
- remove bad route on feed
- Fix issue with custom logos
- Fix unit error

Test Plan: Review on dashboards and on Maniphest homepage

Reviewers: btrahan, epriestley

Reviewed By: epriestley

Subscribers: epriestley, Korvin

Maniphest Tasks: T8099

Differential Revision: https://secure.phabricator.com/D13310
This commit is contained in:
Chad Little 2015-06-16 13:09:48 -07:00 committed by epriestley
parent 69b30c5d53
commit 3846a00916
5 changed files with 12 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
resources/celerity/map.php
View file

@ -7,7 +7,7 @@
*/ */
return array( return array(
'names' => array( 'names' => array(
'core.pkg.css' => 'df56364d', 'core.pkg.css' => '69f486e4',
'core.pkg.js' => '41f5edc5', 'core.pkg.js' => '41f5edc5',
'darkconsole.pkg.js' => 'e7393ebb', 'darkconsole.pkg.js' => 'e7393ebb',
'differential.pkg.css' => 'fe951924', 'differential.pkg.css' => 'fe951924',
@ -141,7 +141,7 @@ return array(
'rsrc/css/phui/phui-info-view.css' => '33e54618', 'rsrc/css/phui/phui-info-view.css' => '33e54618',
'rsrc/css/phui/phui-list.css' => '02ab3534', 'rsrc/css/phui/phui-list.css' => '02ab3534',
'rsrc/css/phui/phui-object-box.css' => '3db9f358', 'rsrc/css/phui/phui-object-box.css' => '3db9f358',
'rsrc/css/phui/phui-object-item-list-view.css' => 'a7d38075', 'rsrc/css/phui/phui-object-item-list-view.css' => '4d5fe709',
'rsrc/css/phui/phui-pager.css' => 'bea33d23', 'rsrc/css/phui/phui-pager.css' => 'bea33d23',
'rsrc/css/phui/phui-pinboard-view.css' => '2495140e', 'rsrc/css/phui/phui-pinboard-view.css' => '2495140e',
'rsrc/css/phui/phui-property-list-view.css' => '1baf23eb', 'rsrc/css/phui/phui-property-list-view.css' => '1baf23eb',
@ -783,7 +783,7 @@ return array(
'phui-inline-comment-view-css' => 'fa5b8d1f', 'phui-inline-comment-view-css' => 'fa5b8d1f',
'phui-list-view-css' => '02ab3534', 'phui-list-view-css' => '02ab3534',
'phui-object-box-css' => '3db9f358', 'phui-object-box-css' => '3db9f358',
'phui-object-item-list-view-css' => 'a7d38075', 'phui-object-item-list-view-css' => '4d5fe709',
'phui-pager-css' => 'bea33d23', 'phui-pager-css' => 'bea33d23',
'phui-pinboard-view-css' => '2495140e', 'phui-pinboard-view-css' => '2495140e',
'phui-property-list-view-css' => '1baf23eb', 'phui-property-list-view-css' => '1baf23eb',

2
src/applications/conpherence/controller/ConpherenceViewController.php
View file

@ -9,7 +9,7 @@ final class ConpherenceViewController extends
return true; return true;
} }
public function buildApplicationCrumbs() { protected function buildApplicationCrumbs() {
$crumbs = $this->buildConpherenceApplicationCrumbs(); $crumbs = $this->buildConpherenceApplicationCrumbs();
$crumbs->setBorder(true); $crumbs->setBorder(true);
return $crumbs; return $crumbs;

2
src/applications/people/application/PhabricatorPeopleApplication.php
View file

@ -73,8 +73,6 @@ final class PhabricatorPeopleApplication extends PhabricatorApplication {
=> 'PhabricatorPeopleProfileController', => 'PhabricatorPeopleProfileController',
'/p/(?P<username>[\w._-]+)/calendar/' '/p/(?P<username>[\w._-]+)/calendar/'
=> 'PhabricatorPeopleCalendarController', => 'PhabricatorPeopleCalendarController',
'/p/(?P<username>[\w._-]+)/feed/'
=> 'PhabricatorPeopleFeedController',
); );
} }

4
src/view/page/menu/PhabricatorMainMenuView.php
View file

@ -274,14 +274,14 @@ final class PhabricatorMainMenuView extends AphrontView {
'background-position: 0px 0px; '. 'background-position: 0px 0px; '.
'background-image: url('.$logo_uri.');'; 'background-image: url('.$logo_uri.');';
} }
} else { }
$color = PhabricatorEnv::getEnvConfig('ui.header-color'); $color = PhabricatorEnv::getEnvConfig('ui.header-color');
if ($color == 'light') { if ($color == 'light') {
$color = 'dark'; $color = 'dark';
} else { } else {
$color = 'light'; $color = 'light';
} }
}
return phutil_tag( return phutil_tag(
'a', 'a',

3
webroot/rsrc/css/phui/phui-object-item-list-view.css
View file

@ -116,7 +116,7 @@ ul.phui-object-item-list-view {
top: 0; top: 0;
bottom: 0; bottom: 0;
left: 0; left: 0;
width: 16px; width: 20px;
background: url('/rsrc/image/texture/grip.png') center center no-repeat; background: url('/rsrc/image/texture/grip.png') center center no-repeat;
} }
@ -151,6 +151,7 @@ ul.phui-object-item-list-view {
width: 20px; width: 20px;
display: table-cell; display: table-cell;
vertical-align: middle; vertical-align: middle;
padding-left: 4px;
} }
.device-phone .phui-object-item-col0 { .device-phone .phui-object-item-col0 {