diff --git a/src/applications/maniphest/editor/ManiphestEditEngine.php b/src/applications/maniphest/editor/ManiphestEditEngine.php index 02066a8089..d30f01a34e 100644 --- a/src/applications/maniphest/editor/ManiphestEditEngine.php +++ b/src/applications/maniphest/editor/ManiphestEditEngine.php @@ -9,6 +9,14 @@ final class ManiphestEditEngine return pht('Maniphest Tasks'); } + public function getSummaryHeader() { + return pht('Configure Maniphest Task Forms'); + } + + public function getSummaryText() { + return pht('Configure how users create and edit tasks.'); + } + public function getEngineApplicationClass() { return 'PhabricatorManiphestApplication'; } diff --git a/src/applications/owners/editor/PhabricatorOwnersPackageEditEngine.php b/src/applications/owners/editor/PhabricatorOwnersPackageEditEngine.php index 943552b20f..62119e6dd6 100644 --- a/src/applications/owners/editor/PhabricatorOwnersPackageEditEngine.php +++ b/src/applications/owners/editor/PhabricatorOwnersPackageEditEngine.php @@ -9,6 +9,14 @@ final class PhabricatorOwnersPackageEditEngine return pht('Owners Packages'); } + public function getSummaryHeader() { + return pht('Configure Owners Package Forms'); + } + + public function getSummaryText() { + return pht('Configure forms for creating and editing packages in Owners.'); + } + public function getEngineApplicationClass() { return 'PhabricatorOwnersApplication'; } diff --git a/src/applications/paste/editor/PhabricatorPasteEditEngine.php b/src/applications/paste/editor/PhabricatorPasteEditEngine.php index 55ae92a194..4cc35ad6e3 100644 --- a/src/applications/paste/editor/PhabricatorPasteEditEngine.php +++ b/src/applications/paste/editor/PhabricatorPasteEditEngine.php @@ -9,6 +9,14 @@ final class PhabricatorPasteEditEngine return pht('Pastes'); } + public function getSummaryHeader() { + return pht('Configure Paste Forms'); + } + + public function getSummaryText() { + return pht('Configure creation and editing forms in Paste.'); + } + public function getEngineApplicationClass() { return 'PhabricatorPasteApplication'; } diff --git a/src/applications/phame/editor/PhameBlogEditEngine.php b/src/applications/phame/editor/PhameBlogEditEngine.php index 292a462ee2..92e267096d 100644 --- a/src/applications/phame/editor/PhameBlogEditEngine.php +++ b/src/applications/phame/editor/PhameBlogEditEngine.php @@ -13,6 +13,14 @@ final class PhameBlogEditEngine return 'PhabricatorPhameApplication'; } + public function getSummaryHeader() { + return pht('Configure Phame Blog Forms'); + } + + public function getSummaryText() { + return pht('Configure how blogs in Phame are created and edited.'); + } + protected function newEditableObject() { return PhameBlog::initializeNewBlog($this->getViewer()); } diff --git a/src/applications/transactions/editengine/PhabricatorEditEngine.php b/src/applications/transactions/editengine/PhabricatorEditEngine.php index 3e2ee9bba9..587c48c9c8 100644 --- a/src/applications/transactions/editengine/PhabricatorEditEngine.php +++ b/src/applications/transactions/editengine/PhabricatorEditEngine.php @@ -225,6 +225,27 @@ abstract class PhabricatorEditEngine } + /** + * Return a human-readable header describing what this engine is used to do, + * like "Configure Maniphest Task Forms". + * + * @return string Human-readable description of the engine. + * @task text + */ + abstract public function getSummaryHeader(); + + + /** + * Return a human-readable summary of what this engine is used to do. + * + * @return string Human-readable description of the engine. + * @task text + */ + abstract public function getSummaryText(); + + + + /* -( Edit Engine Configuration )------------------------------------------ */ @@ -1010,9 +1031,9 @@ abstract class PhabricatorEditEngine $action_button = id(new PHUIButtonView()) ->setTag('a') - ->setText(pht('Actions')) + ->setText(pht('Configure Form')) ->setHref('#') - ->setIconFont('fa-bars') + ->setIconFont('fa-gear') ->setDropdownMenu($action_view); return $action_button; diff --git a/src/applications/transactions/editor/PhabricatorEditEngineConfigurationEditEngine.php b/src/applications/transactions/editor/PhabricatorEditEngineConfigurationEditEngine.php index 0c1c4787db..0305c19015 100644 --- a/src/applications/transactions/editor/PhabricatorEditEngineConfigurationEditEngine.php +++ b/src/applications/transactions/editor/PhabricatorEditEngineConfigurationEditEngine.php @@ -30,6 +30,16 @@ final class PhabricatorEditEngineConfigurationEditEngine return pht('Edit Configurations'); } + public function getSummaryHeader() { + return pht('Configure Forms for Configuring Forms'); + } + + public function getSummaryText() { + return pht( + 'Change how forms in other applications are created and edited. '. + 'Advanced!'); + } + public function getEngineApplicationClass() { return 'PhabricatorTransactionsApplication'; } diff --git a/src/applications/transactions/query/PhabricatorEditEngineSearchEngine.php b/src/applications/transactions/query/PhabricatorEditEngineSearchEngine.php index 7b86d34bd9..b2959a8596 100644 --- a/src/applications/transactions/query/PhabricatorEditEngineSearchEngine.php +++ b/src/applications/transactions/query/PhabricatorEditEngineSearchEngine.php @@ -65,9 +65,14 @@ final class PhabricatorEditEngineSearchEngine $engine_key = $engine->getEngineKey(); $query_uri = "/transactions/editengine/{$engine_key}/"; + $application = $engine->getApplication(); + $app_icon = $application->getFontIcon(); + $item = id(new PHUIObjectItemView()) - ->setHeader($engine->getEngineName()) - ->setHref($query_uri); + ->setHeader($engine->getSummaryHeader()) + ->setHref($query_uri) + ->setStatusIcon($app_icon) + ->addAttribute($engine->getSummaryText()); $list->addItem($item); }