From 38e359cb13cf979aee61c1ce3d31eaf0d4c0fa3e Mon Sep 17 00:00:00 2001 From: Andre Klapper Date: Wed, 24 Jul 2024 18:35:31 +0200 Subject: [PATCH] Fix non-existing log method in HarbormasterManagementRestartWorkflow Summary: In `HarbormasterManagementRestartWorkflow`, `logSkip()` is called. A method with such a name has never existed in `PhabricatorManagementWorkflow`. Given the five available `log*()` methods, replace the call with `logInfo()` which seems most appropriate. Test Plan: Run static code analysis which complains about `Call to an undefined method HarbormasterManagementRestartWorkflow::logSkip()`; read the code. Reviewers: O1 Blessed Committers, valerio.bozzolan Reviewed By: O1 Blessed Committers, valerio.bozzolan Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Tags: #almanac_drydock_harbormaster Differential Revision: https://we.phorge.it/D25742 --- .../management/HarbormasterManagementRestartWorkflow.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/applications/harbormaster/management/HarbormasterManagementRestartWorkflow.php b/src/applications/harbormaster/management/HarbormasterManagementRestartWorkflow.php index 568bef46ac..0f311d3bb3 100644 --- a/src/applications/harbormaster/management/HarbormasterManagementRestartWorkflow.php +++ b/src/applications/harbormaster/management/HarbormasterManagementRestartWorkflow.php @@ -50,7 +50,7 @@ final class HarbormasterManagementRestartWorkflow $count = count($builds); if (!$count) { - $this->logSkip( + $this->logInfo( pht('SKIP'), pht('No builds to restart.')); return 0;