revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-25 16:22:43 +01:00
Code Issues Releases Wiki Activity

Set base-uri as User-Agent for OAuth1 and Github authentication

Browse source 
Summary: Closes T15848

Test Plan: Unclear.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: RhinosF1, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15848

Differential Revision: https://we.phorge.it/D25758
This commit is contained in:
Andre Klapper 2024-08-01 16:29:41 +02:00
parent 0fe0b9f681
commit 39237c0854
2 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/applications/auth/adapter/PhutilGitHubAuthAdapter.php
View file

@ -55,7 +55,8 @@ final class PhutilGitHubAuthAdapter extends PhutilOAuthAuthAdapter {
$future = new HTTPSFuture($uri); $future = new HTTPSFuture($uri);
// NOTE: GitHub requires a User-Agent string. // NOTE: GitHub requires a User-Agent string.
$future->addHeader('User-Agent', __CLASS__); $future->addHeader('User-Agent',
PhabricatorEnv::getEnvConfig('phabricator.base-uri'));
// See T13485. Circa early 2020, GitHub has deprecated use of the // See T13485. Circa early 2020, GitHub has deprecated use of the
// "access_token" URI parameter. // "access_token" URI parameter.

2
src/applications/auth/adapter/PhutilOAuth1AuthAdapter.php
View file

@ -100,6 +100,8 @@ abstract class PhutilOAuth1AuthAdapter extends PhutilAuthAdapter {
protected function newOAuth1Future($uri, $data = array()) { protected function newOAuth1Future($uri, $data = array()) {
$future = id(new PhutilOAuth1Future($uri, $data)) $future = id(new PhutilOAuth1Future($uri, $data))
->addHeader('User-Agent',
PhabricatorEnv::getEnvConfig('phabricator.base-uri'))
->setMethod('POST') ->setMethod('POST')
->setSignatureMethod($this->getSignatureMethod()); ->setSignatureMethod($this->getSignatureMethod());