From 3955ff719a3d82a840cb75055314819681a568bf Mon Sep 17 00:00:00 2001 From: lkassianik Date: Mon, 28 Mar 2016 10:21:20 -0700 Subject: [PATCH] Create feed transaction stories for awarding/revoking badges Summary: Ref T10677, Awarding/revoking badge should create a feed story on homepage with badge handle recipient handles Test Plan: Award/revoke badge, open Feed, should see story with badge link and recipient links. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin Maniphest Tasks: T10677 Differential Revision: https://secure.phabricator.com/D15534 --- .../storage/PhabricatorBadgesTransaction.php | 22 +++++++++++++++++++ .../PhabricatorUSEnglishTranslation.php | 14 ++++++++++++ 2 files changed, 36 insertions(+) diff --git a/src/applications/badges/storage/PhabricatorBadgesTransaction.php b/src/applications/badges/storage/PhabricatorBadgesTransaction.php index dc92d1fc8f..c8da36eda4 100644 --- a/src/applications/badges/storage/PhabricatorBadgesTransaction.php +++ b/src/applications/badges/storage/PhabricatorBadgesTransaction.php @@ -191,6 +191,28 @@ final class PhabricatorBadgesTransaction $this->renderHandleLink($object_phid)); } break; + case self::TYPE_AWARD: + if (!is_array($new)) { + $new = array(); + } + $handles = $this->renderHandleList($new); + return pht( + '%s awarded %s to %s recipient(s): %s.', + $this->renderHandleLink($author_phid), + $this->renderHandleLink($object_phid), + new PhutilNumber(count($new)), + $handles); + case self::TYPE_REVOKE: + if (!is_array($new)) { + $new = array(); + } + $handles = $this->renderHandleList($new); + return pht( + '%s revoked %s from %s recipient(s): %s.', + $this->renderHandleLink($author_phid), + $this->renderHandleLink($object_phid), + new PhutilNumber(count($new)), + $handles); } return parent::getTitleForFeed(); diff --git a/src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php b/src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php index 54e69476d4..492d68dd1b 100644 --- a/src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php +++ b/src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php @@ -1542,6 +1542,20 @@ final class PhabricatorUSEnglishTranslation '%s revoked this badge from recipients: %3$s.', ), ), + + '%s awarded %s to %s recipient(s): %s.' => array( + array( + '%s awarded %s to recipient: %4$s.', + '%s awarded %s to recipients: %4$s.', + ), + ), + + '%s revoked %s from %s recipient(s): %s.' => array( + array( + '%s revoked %s from recipient: %4$s.', + '%s revoked %s from recipients: %4$s.', + ), + ), ); }