revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-29 10:12:41 +01:00
Code Issues Releases Wiki Activity

Make the "attach_inlines" parameter to "differential.createcomment" a no-op

Browse source 
Summary: Ref T13513. See that task for some discussion. This prepares to lift "loadUnsubmittedInlineComments(...)" into shared code.

Test Plan: Grepped for callers, found none in the upstream. This is a backward compatibilty break. See T13513.

Maniphest Tasks: T13513

Differential Revision: https://secure.phabricator.com/D21225
This commit is contained in:
epriestley 2020-05-06 11:23:01 -07:00
parent 0067f1a521
commit 397648855f
1 changed files with 2 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
src/applications/differential/conduit/DifferentialCreateCommentConduitAPIMethod.php
View file

@ -94,17 +94,8 @@ final class DifferentialCreateCommentConduitAPIMethod
->setContent($content)); ->setContent($content));
} }
if ($request->getValue('attach_inlines')) { // NOTE: The legacy "attach_inlines" flag is now ignored and has no
$type_inline = DifferentialTransaction::TYPE_INLINE; // effect. See T13513.
$inlines = DifferentialTransactionQuery::loadUnsubmittedInlineComments(
$viewer,
$revision);
foreach ($inlines as $inline) {
$xactions[] = id(new DifferentialTransaction())
->setTransactionType($type_inline)
->attachComment($inline);
}
}
// NOTE: The legacy "silent" flag is now ignored and has no effect. See // NOTE: The legacy "silent" flag is now ignored and has no effect. See
// T13042. // T13042.