revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-09 16:32:39 +01:00
Code Issues Releases Wiki Activity

Suggest STRICT_ALL_TABLES during setup. Improve dev-mode comments.

Browse source 
Summary: Suggest the MySQL mode STRICT_ALL_TABLES during setup if it is not set. Small improvement to the phabricator.developer-mode comments.

Test Plan: Set the global sql_mode to include or exclude STRICT_ALL_TABLES and check for desired behavior.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D4803
This commit is contained in:
Bryan Cuccioli 2013-02-04 09:03:19 -08:00 committed by epriestley
parent 5a2be27045
commit 39afb3fedb
2 changed files with 16 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
conf/default.conf.php
View file

@ -801,7 +801,8 @@ return array(
// Show stack traces when unhandled exceptions occur, force reloading of // Show stack traces when unhandled exceptions occur, force reloading of
// static resources (skipping the cache), show an error callout if a page // static resources (skipping the cache), show an error callout if a page
// generated PHP errors, warnings, or notices, force disk reads when // generated PHP errors, warnings, or notices, force disk reads when
// reloading. This option should not be enabled in production. // reloading, and generally make development easier. This option should not
// be enabled in production.
'phabricator.developer-mode' => false, 'phabricator.developer-mode' => false,
// When users write comments which have URIs, they'll be automatically linked // When users write comments which have URIs, they'll be automatically linked

14
src/applications/config/check/PhabricatorSetupCheckDatabase.php
View file

@ -65,6 +65,20 @@ final class PhabricatorSetupCheckDatabase extends PhabricatorSetupCheck {
return; return;
} }
if (PhabricatorEnv::getEnvConfig('phabricator.developer-mode')) {
$mode_string = queryfx_one($conn_raw, "SELECT @@sql_mode");
$modes = explode(',', $mode_string['@@sql_mode']);
if (!in_array('STRICT_ALL_TABLES', $modes)) {
$message = pht(
"The global sql_mode is not set to 'STRICT_ALL_TABLES'. It is ".
"recommended that you set this mode while developing Phabricator.");
$this->newIssue('mysql.mode')
->setName(pht('MySQL STRICT_ALL_TABLES mode not set.'))
->setMessage($message);
}
}
$namespace = PhabricatorEnv::getEnvConfig('storage.default-namespace'); $namespace = PhabricatorEnv::getEnvConfig('storage.default-namespace');
$databases = queryfx_all($conn_raw, 'SHOW DATABASES'); $databases = queryfx_all($conn_raw, 'SHOW DATABASES');