revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-02-16 16:58:38 +01:00
Code Issues Releases Wiki Activity

Add HTML header for Atom/RSS discovery on Phame blog pages

Browse source 
Summary:
Allow easier discovery and subscribing to Atom feeds of Phame blogs.

To be extra cautious, also make sure that the added line is a `PhutilSafeHTML`.

Original author: @20after4

Closes T15550

Test Plan: Go to `/phame/blog/view/1/` and check the HTML source code. See an additional `<link>` item with `type="application/atom+xml"` in the `<head>` section.

Reviewers: O1 Blessed Committers, avivey

Reviewed By: O1 Blessed Committers, avivey

Subscribers: avivey, speck, tobiaswiese, valerio.bozzolan, Matthew, 20after4, Cigaryno

Maniphest Tasks: T15550

Differential Revision: https://we.phorge.it/D25346
This commit is contained in:
Andre Klapper 2023-08-05 23:23:05 +02:00
parent 9fe2bfebe8
commit 39b576b145
3 changed files with 33 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/applications/phame/controller/blog/PhameBlogViewController.php
View file

@ -117,6 +117,15 @@ final class PhameBlogViewController extends PhameLiveController {
$about, $about,
)); ));
$page->addHeadItem(phutil_tag(
'link',
array(
'rel' => 'alternate',
'type' => 'application/atom+xml',
'href' => $blog->getFeedURI(),
'title' => $blog->getName(),
)));
return $page; return $page;
} }

9
src/applications/phame/storage/PhameBlog.php
View file

@ -200,6 +200,15 @@ final class PhameBlog extends PhameDAO
return '/phame/blog/manage/'.$this->getID().'/'; return '/phame/blog/manage/'.$this->getID().'/';
} }
/**
* Get relative URI of Phame blog feed.
*
* @return string Relative URI of Phame blog feed
*/
public function getFeedURI() {
return '/phame/blog/feed/'.$this->getID().'/';
}
public function getProfileImageURI() { public function getProfileImageURI() {
return $this->getProfileImageFile()->getBestURI(); return $this->getProfileImageFile()->getBestURI();
} }

16
src/view/page/PhabricatorStandardPageView.php
View file

@ -23,6 +23,7 @@ final class PhabricatorStandardPageView extends PhabricatorBarePageView
private $crumbs; private $crumbs;
private $navigation; private $navigation;
private $footer; private $footer;
private $headItems = array();
public function setShowFooter($show_footer) { public function setShowFooter($show_footer) {
$this->showFooter = $show_footer; $this->showFooter = $show_footer;
@ -375,6 +376,18 @@ final class PhabricatorStandardPageView extends PhabricatorBarePageView
} }
/**
* Insert a HTML element into <head> of the page to render.
* Used by PhameBlogViewController.
*
* @param PhutilSafeHTML HTML header to add
*/
public function addHeadItem($html) {
if ($html instanceof PhutilSafeHTML) {
$this->headItems[] = $html;
}
}
protected function getHead() { protected function getHead() {
$monospaced = null; $monospaced = null;
@ -407,9 +420,10 @@ final class PhabricatorStandardPageView extends PhabricatorBarePageView
} }
return hsprintf( return hsprintf(
'%s%s%s', '%s%s%s%s',
parent::getHead(), parent::getHead(),
$font_css, $font_css,
phutil_implode_html('', $this->headItems),
$response->renderSingleResource('javelin-magical-init', 'phabricator')); $response->renderSingleResource('javelin-magical-init', 'phabricator'));
} }