mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-19 13:22:42 +01:00
Add objectPHID
keys to Harbormaster task schedulers
Summary: Fixes T9816. It's currently hard to hunt down some particulars in the worker queue if things go awry in Harbormaster. Supplement the queue with `objectPHID` keys so we can hunt tasks down more easily if the issues in T9816 continue. Test Plan: ``` mysql> select * from worker_archivetask order by id desc limit 30; +--------+------------------------------------------------+-----------------------------------+--------------+--------------+--------+--------+----------+-------------+--------------+----------+--------------------------------+ | id | taskClass | leaseOwner | leaseExpires | failureCount | dataID | result | duration | dateCreated | dateModified | priority | objectPHID | +--------+------------------------------------------------+-----------------------------------+--------------+--------------+--------+--------+----------+-------------+--------------+----------+--------------------------------+ | 496024 | HarbormasterTargetWorker | 8514:1448232248:Orbital.local:3 | 1448318648 | 0 | 311880 | 0 | 233758 | 1448232248 | 1448232248 | 2000 | PHID-HMBT-thq4oof4byllmbc4q3tt | | 496023 | PhabricatorApplicationTransactionPublishWorker | 8514:1448232247:Orbital.local:1 | 1448239447 | 0 | 311879 | 0 | 53731 | 1448232247 | 1448232247 | 1000 | PHID-HMBD-i6zo2ltc73rre7o54s7v | | 496022 | HarbormasterBuildWorker | 8514:1448232247:Orbital.local:2 | 1448239447 | 0 | 311878 | 0 | 30736 | 1448232248 | 1448232248 | 2000 | PHID-HMBD-i6zo2ltc73rre7o54s7v | ... ``` Reviewers: chad Reviewed By: chad Maniphest Tasks: T9816 Differential Revision: https://secure.phabricator.com/D14541
This commit is contained in:
parent
06aa3a0a1b
commit
39cf013472
4 changed files with 15 additions and 1 deletions
|
@ -256,10 +256,15 @@ final class HarbormasterSendMessageConduitAPIMethod
|
||||||
|
|
||||||
// If the build has completely paused because all steps are blocked on
|
// If the build has completely paused because all steps are blocked on
|
||||||
// waiting targets, this will resume it.
|
// waiting targets, this will resume it.
|
||||||
|
$build = $build_target->getBuild();
|
||||||
|
|
||||||
PhabricatorWorker::scheduleTask(
|
PhabricatorWorker::scheduleTask(
|
||||||
'HarbormasterBuildWorker',
|
'HarbormasterBuildWorker',
|
||||||
array(
|
array(
|
||||||
'buildID' => $build_target->getBuild()->getID(),
|
'buildID' => $build->getID(),
|
||||||
|
),
|
||||||
|
array(
|
||||||
|
'objectPHID' => $build->getPHID(),
|
||||||
));
|
));
|
||||||
|
|
||||||
return null;
|
return null;
|
||||||
|
|
|
@ -98,6 +98,9 @@ final class HarbormasterBuildTransactionEditor
|
||||||
'HarbormasterBuildWorker',
|
'HarbormasterBuildWorker',
|
||||||
array(
|
array(
|
||||||
'buildID' => $build->getID(),
|
'buildID' => $build->getID(),
|
||||||
|
),
|
||||||
|
array(
|
||||||
|
'objectPHID' => $build->getPHID(),
|
||||||
));
|
));
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
@ -81,6 +81,9 @@ final class HarbormasterBuildEngine extends Phobject {
|
||||||
'HarbormasterTargetWorker',
|
'HarbormasterTargetWorker',
|
||||||
array(
|
array(
|
||||||
'targetID' => $target->getID(),
|
'targetID' => $target->getID(),
|
||||||
|
),
|
||||||
|
array(
|
||||||
|
'objectPHID' => $target->getPHID(),
|
||||||
));
|
));
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
@ -184,6 +184,9 @@ final class HarbormasterBuildable extends HarbormasterDAO
|
||||||
'HarbormasterBuildWorker',
|
'HarbormasterBuildWorker',
|
||||||
array(
|
array(
|
||||||
'buildID' => $build->getID(),
|
'buildID' => $build->getID(),
|
||||||
|
),
|
||||||
|
array(
|
||||||
|
'objectPHID' => $build->getPHID(),
|
||||||
));
|
));
|
||||||
|
|
||||||
return $build;
|
return $build;
|
||||||
|
|
Loading…
Reference in a new issue