From 3a881f5108d9cf77ea3b4016861229549a35e56b Mon Sep 17 00:00:00 2001 From: epriestley Date: Thu, 24 Apr 2014 08:11:13 -0700 Subject: [PATCH] Put "Task" first on global search result type list Summary: Fixes T4606. Also shortens two unusual type names which are currently inconsistent. Test Plan: Expanded advanced search. Reviewers: chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T4606 Differential Revision: https://secure.phabricator.com/D8853 --- .../differential/phid/DifferentialPHIDTypeRevision.php | 2 +- .../people/phid/PhabricatorPeoplePHIDTypeUser.php | 2 +- .../query/PhabricatorSearchApplicationSearchEngine.php | 7 +++++++ 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/src/applications/differential/phid/DifferentialPHIDTypeRevision.php b/src/applications/differential/phid/DifferentialPHIDTypeRevision.php index f576e0e062..9a815e150d 100644 --- a/src/applications/differential/phid/DifferentialPHIDTypeRevision.php +++ b/src/applications/differential/phid/DifferentialPHIDTypeRevision.php @@ -9,7 +9,7 @@ final class DifferentialPHIDTypeRevision extends PhabricatorPHIDType { } public function getTypeName() { - return pht('Differential Revision'); + return pht('Revision'); } public function newObject() { diff --git a/src/applications/people/phid/PhabricatorPeoplePHIDTypeUser.php b/src/applications/people/phid/PhabricatorPeoplePHIDTypeUser.php index c84607994f..9afc7c7fa4 100644 --- a/src/applications/people/phid/PhabricatorPeoplePHIDTypeUser.php +++ b/src/applications/people/phid/PhabricatorPeoplePHIDTypeUser.php @@ -9,7 +9,7 @@ final class PhabricatorPeoplePHIDTypeUser extends PhabricatorPHIDType { } public function getTypeName() { - return pht('Phabricator User'); + return pht('User'); } public function getTypeIcon() { diff --git a/src/applications/search/query/PhabricatorSearchApplicationSearchEngine.php b/src/applications/search/query/PhabricatorSearchApplicationSearchEngine.php index d9a32f7e7a..d68558e6a0 100644 --- a/src/applications/search/query/PhabricatorSearchApplicationSearchEngine.php +++ b/src/applications/search/query/PhabricatorSearchApplicationSearchEngine.php @@ -216,6 +216,13 @@ final class PhabricatorSearchApplicationSearchEngine asort($results); + // Put tasks first, see T4606. + $results = array_select_keys( + $results, + array( + ManiphestPHIDTypeTask::TYPECONST, + )) + $results; + return $results; }