From 3b2868e155531886361db26d92c838a74ff4fe87 Mon Sep 17 00:00:00 2001 From: Christopher Speck Date: Sat, 4 Sep 2021 13:44:09 -0400 Subject: [PATCH] Fix searching legalpad documents by contributors Summary: Found in a change submitted to Phorge (https://we.phorge.it/D25018#inline-231), this fixes a typo in populating search the `contributorPHIDs` constraint in the Legalpad search engine. Currently when trying to search legalpad documents by contributor an error is encountered: ```lang=console Array for %Ls conversion is empty. Query: contributor.dst IN (%Ls) ``` Test Plan: I searched for legalpad documents based on a contributor and got back correct results. Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D21719 --- .../legalpad/query/LegalpadDocumentSearchEngine.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/applications/legalpad/query/LegalpadDocumentSearchEngine.php b/src/applications/legalpad/query/LegalpadDocumentSearchEngine.php index a245417483..8c4dd31ff1 100644 --- a/src/applications/legalpad/query/LegalpadDocumentSearchEngine.php +++ b/src/applications/legalpad/query/LegalpadDocumentSearchEngine.php @@ -53,7 +53,7 @@ final class LegalpadDocumentSearchEngine } if ($map['contributorPHIDs']) { - $query->withContributorPHIDs($map['creatorPHIDs']); + $query->withContributorPHIDs($map['contributorPHIDs']); } if ($map['creatorPHIDs']) {