From 3b2fa99c57db96fe446b54ac50d271e6974265b1 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Fri, 24 Apr 2015 14:26:00 -0700
Subject: [PATCH] Fix an issue in legalpad when signing with a registered email
 address

Summary: If you're logged out and try to sign a document with a registered email address, we don't handle telling you to login correctly.

Test Plan: Tried to sign with a registered address, got a helpful dialog instead of a fatal.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D12544
---
 .../legalpad/controller/LegalpadDocumentSignController.php  | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/applications/legalpad/controller/LegalpadDocumentSignController.php b/src/applications/legalpad/controller/LegalpadDocumentSignController.php
index 7a0018924d..b1c23f5d9a 100644
--- a/src/applications/legalpad/controller/LegalpadDocumentSignController.php
+++ b/src/applications/legalpad/controller/LegalpadDocumentSignController.php
@@ -22,9 +22,13 @@ final class LegalpadDocumentSignController extends LegalpadController {
       return new Aphront404Response();
     }
 
-    list($signer_phid, $signature_data) = $this->readSignerInformation(
+    $information = $this->readSignerInformation(
       $document,
       $request);
+    if ($information instanceof AphrontResponse) {
+      return $information;
+    }
+    list($signer_phid, $signature_data) = $information;
 
     $signature = null;