From 3b33089de7f6a9976681ad382d1d3266ecafb97f Mon Sep 17 00:00:00 2001 From: Chad Little Date: Fri, 4 Apr 2014 14:00:28 -0700 Subject: [PATCH] Don't show 'needs review' on DifferentialObjects Summary: This text is overly repetitive and is not super important. Keeps the other states. Also - Easier to parse reviewers now - Mobile is less janky Test Plan: reload my list of diffs {F138756} Reviewers: epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D8707 --- .../differential/view/DifferentialRevisionListView.php | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/applications/differential/view/DifferentialRevisionListView.php b/src/applications/differential/view/DifferentialRevisionListView.php index 636390feaa..0385116848 100644 --- a/src/applications/differential/view/DifferentialRevisionListView.php +++ b/src/applications/differential/view/DifferentialRevisionListView.php @@ -138,7 +138,10 @@ final class DifferentialRevisionListView extends AphrontView { $item->addAttribute($draft); } - $item->addAttribute($status_name); + /* Most things 'Need Review', so accept it's the default */ + if ($status != ArcanistDifferentialRevisionStatus::NEEDS_REVIEW) { + $item->addAttribute($status_name); + } // Author $author_handle = $this->handles[$revision->getAuthorPHID()];