revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-18 12:52:42 +01:00
Code Issues Releases Wiki Activity

Clean up parentDomain issues in PhameBlog

Browse source 
Summary: Ref T9360. These weren't getting set properly, also make them nullable since they're optional.

Test Plan: run upgrade, make a new blog with and without a parent domain. Edit a current blog.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Maniphest Tasks: T9360

Differential Revision: https://secure.phabricator.com/D16242
This commit is contained in:
Chad Little 2016-07-06 13:45:42 -07:00
parent 15f9e0f6ea
commit 3bed16e750
4 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
resources/sql/autopatches/20160706.phame.blog.parentdomain.2.sql Normal file
View file

@ -0,0 +1,2 @@
ALTER TABLE {$NAMESPACE}_phame.phame_blog
MODIFY parentDomain VARCHAR(128) NULL COLLATE {$COLLATE_TEXT};

2
resources/sql/autopatches/20160706.phame.blog.parentsite.1.sql Normal file
View file

@ -0,0 +1,2 @@
ALTER TABLE {$NAMESPACE}_phame.phame_blog
MODIFY parentSite VARCHAR(128) NULL COLLATE {$COLLATE_TEXT};

1
src/applications/phame/editor/PhameBlogEditor.php
View file

@ -66,6 +66,7 @@ final class PhameBlogEditor
case PhameBlogTransaction::TYPE_DESCRIPTION: case PhameBlogTransaction::TYPE_DESCRIPTION:
case PhameBlogTransaction::TYPE_STATUS: case PhameBlogTransaction::TYPE_STATUS:
case PhameBlogTransaction::TYPE_PARENTSITE: case PhameBlogTransaction::TYPE_PARENTSITE:
case PhameBlogTransaction::TYPE_PARENTDOMAIN:
case PhameBlogTransaction::TYPE_PROFILEIMAGE: case PhameBlogTransaction::TYPE_PROFILEIMAGE:
case PhameBlogTransaction::TYPE_HEADERIMAGE: case PhameBlogTransaction::TYPE_HEADERIMAGE:
return $xaction->getNewValue(); return $xaction->getNewValue();

4
src/applications/phame/storage/PhameBlog.php
View file

@ -48,8 +48,8 @@ final class PhameBlog extends PhameDAO
'description' => 'text', 'description' => 'text',
'domain' => 'text128?', 'domain' => 'text128?',
'domainFullURI' => 'text128?', 'domainFullURI' => 'text128?',
'parentSite' => 'text128', 'parentSite' => 'text128?',
'parentDomain' => 'text128', 'parentDomain' => 'text128?',
'status' => 'text32', 'status' => 'text32',
'mailKey' => 'bytes20', 'mailKey' => 'bytes20',
'profileImagePHID' => 'phid?', 'profileImagePHID' => 'phid?',