improve calendar status editing

Summary: make it so a given user can click to edit status from calendar view. also fix bug so when editing status existing "type" is selected

Test Plan: edited status from calendar view and observed "sporadic" status sticky

Reviewers: epriestley, chad

Reviewed By: chad

CC: aran, Korvin

Maniphest Tasks: T2060, T2061

Differential Revision: https://secure.phabricator.com/D3957

src/applications/calendar/controller/PhabricatorCalendarBrowseController.php

@@ -46,6 +46,7 @@ final class PhabricatorCalendarBrowseController
       $event->setDescription(
         $status->getTerseSummary($user).$details
       );
+      $event->setEventID($status->getID());
       $month_view->addEvent($event);
     }
 

src/applications/calendar/controller/PhabricatorCalendarEditStatusController.php

@@ -102,6 +102,7 @@ final class PhabricatorCalendarEditStatusController
     $status_select = id(new AphrontFormSelectControl())
       ->setLabel(pht('Status'))
       ->setName('status')
+      ->setValue($status->getStatus())
       ->setOptions($status->getStatusOptions());
 
     $description = id(new AphrontFormTextAreaControl())

src/applications/calendar/view/AphrontCalendarEventView.php

@@ -7,6 +7,15 @@ final class AphrontCalendarEventView extends AphrontView {
   private $epochStart;
   private $epochEnd;
   private $description;
+  private $eventID;
+
+  public function setEventID($event_id) {
+    $this->eventID = $event_id;
+    return $this;
+  }
+  public function getEventID() {
+    return $this->eventID;
+  }
 
   public function setUserPHID($user_phid) {
     $this->userPHID = $user_phid;

src/applications/calendar/view/AphrontCalendarMonthView.php

@@ -289,8 +289,16 @@ final class AphrontCalendarMonthView extends AphrontView {
       $info .= "\n\n".$event->getDescription();
     }
 
+    if ($user->getPHID() == $event->getUserPHID()) {
+      $tag  = 'a';
+      $href = '/calendar/status/edit/'.$event->getEventID().'/';
+    } else {
+      $tag  = 'div';
+      $href = null;
+    }
+
     $text_div = javelin_render_tag(
-      'div',
+      $tag,
       array(
         'sigil' => 'has-tooltip',
         'meta'  => array(
@@ -298,6 +306,7 @@ final class AphrontCalendarMonthView extends AphrontView {
           'size' => 240,
         ),
         'class' => 'aphront-calendar-event-text',
+        'href'  => $href,
       ),
       phutil_escape_html(phutil_utf8_shorten($event->getName(), 32)));