From 3c213759300d4294a5d047b2fb77b2bb666b1663 Mon Sep 17 00:00:00 2001
From: Chad Little <chad@chadsdomain.com>
Date: Sun, 24 Nov 2013 19:14:16 -0800
Subject: [PATCH] Clean up external accounts page

Summary: Touched up the layout, css of this page

Test Plan: Viewed linked and linkable accounts. Tested mobile layout

Reviewers: epriestley

Reviewed By: epriestley

CC: Korvin, epriestley, aran

Differential Revision: https://secure.phabricator.com/D7644
---
 src/__celerity_resource_map__.php                |  4 ++--
 .../PhabricatorSettingsPanelExternalAccounts.php | 16 ++++++++++++----
 webroot/rsrc/css/application/auth/auth.css       |  4 ++--
 3 files changed, 16 insertions(+), 8 deletions(-)

diff --git a/src/__celerity_resource_map__.php b/src/__celerity_resource_map__.php
index 0521167e90..019d4504d4 100644
--- a/src/__celerity_resource_map__.php
+++ b/src/__celerity_resource_map__.php
@@ -975,7 +975,7 @@ celerity_register_resource_map(array(
   ),
   'auth-css' =>
   array(
-    'uri' => '/res/9e544d3c/rsrc/css/application/auth/auth.css',
+    'uri' => '/res/a55f96ce/rsrc/css/application/auth/auth.css',
     'type' => 'css',
     'requires' =>
     array(
@@ -3551,7 +3551,7 @@ celerity_register_resource_map(array(
   ),
   'phabricator-source-code-view-css' =>
   array(
-    'uri' => '/res/aee63670/rsrc/css/layout/phabricator-source-code-view.css',
+    'uri' => '/res/f70ef208/rsrc/css/layout/phabricator-source-code-view.css',
     'type' => 'css',
     'requires' =>
     array(
diff --git a/src/applications/settings/panel/PhabricatorSettingsPanelExternalAccounts.php b/src/applications/settings/panel/PhabricatorSettingsPanelExternalAccounts.php
index 3411ef5ec5..8fce71e9af 100644
--- a/src/applications/settings/panel/PhabricatorSettingsPanelExternalAccounts.php
+++ b/src/applications/settings/panel/PhabricatorSettingsPanelExternalAccounts.php
@@ -35,6 +35,7 @@ final class PhabricatorSettingsPanelExternalAccounts
 
     $linked = id(new PHUIObjectItemListView())
       ->setUser($viewer)
+      ->setCards(true)
       ->setNoDataString(pht('You have no linked accounts.'));
 
     $login_accounts = 0;
@@ -97,6 +98,7 @@ final class PhabricatorSettingsPanelExternalAccounts
 
     $linkable = id(new PHUIObjectItemListView())
       ->setUser($viewer)
+      ->setCards(true)
       ->setNoDataString(
         pht('Your account is linked with all available providers.'));
 
@@ -126,11 +128,17 @@ final class PhabricatorSettingsPanelExternalAccounts
       $linkable->addItem($item);
     }
 
+    $linked_box = id(new PHUIObjectBoxView())
+      ->setHeader($linked_head)
+      ->appendChild($linked);
+
+    $linkable_box = id(new PHUIObjectBoxView())
+      ->setHeader($linkable_head)
+      ->appendChild($linkable);
+
     return array(
-      $linked_head,
-      $linked,
-      $linkable_head,
-      $linkable,
+      $linked_box,
+      $linkable_box,
     );
   }
 
diff --git a/webroot/rsrc/css/application/auth/auth.css b/webroot/rsrc/css/application/auth/auth.css
index cf73e30682..219c8795a3 100644
--- a/webroot/rsrc/css/application/auth/auth.css
+++ b/webroot/rsrc/css/application/auth/auth.css
@@ -24,13 +24,13 @@
 }
 
 .auth-account-view {
-  border: 1px solid #aaaaaa;
+  background-color: #fff;
+  border: 1px solid {$lightblueborder};
   background-repeat: no-repeat;
   background-position: 4px 4px;
   padding: 4px 4px 4px 62px;
   min-height: 50px;
   border-radius: 2px;
-  box-shadow: 0 1px 3px rgba(0, 0, 0, 0.15);
 }
 
 .auth-account-view-name {