Minor formatting changes

Summary: Apply some autofix linter rules.

Test Plan: `arc lint` and `arc unit`

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: epriestley, Korvin, hach-que

Differential Revision: https://secure.phabricator.com/D10585

scripts/symbols/generate_php_symbols.php

@@ -98,7 +98,7 @@ foreach (Futures($futures)->limit(8) as $file => $future) {
   }
 }
 
-function print_symbol($file, $type, $token, $context=null) {
+function print_symbol($file, $type, $token, $context = null) {
   $parts = array(
     $context ? $context->getConcreteString() : '',
     // variable tokens are `$name`, not just `name`, so strip the $ off of

src/aphront/configuration/AphrontDefaultApplicationConfiguration.php

@@ -306,7 +306,8 @@ class AphrontDefaultApplicationConfiguration
       array(
         'uri' => $uri,
         'external' => $external,
-      ));
+      ),
+    );
   }
 
 }

src/aphront/console/plugin/DarkConsoleRequestPlugin.php

@@ -47,7 +47,8 @@ final class DarkConsoleRequestPlugin extends DarkConsolePlugin {
         if (isset($mask[$key])) {
           $rows[] = array(
             $key,
-            phutil_tag('em', array(), '(Masked)'));
+            phutil_tag('em', array(), '(Masked)'),
+          );
         } else {
           $rows[] = array(
             $key,

src/aphront/response/AphrontFileResponse.php

@@ -82,7 +82,8 @@ final class AphrontFileResponse extends AphrontResponse {
     if ($this->allowOrigins) {
       $headers[] = array(
         'Access-Control-Allow-Origin',
-        implode(',', $this->allowOrigins));
+        implode(',', $this->allowOrigins),
+      );
     }
 
     $headers = array_merge(parent::getHeaders(), $headers);

src/aphront/response/AphrontResponse.php

@@ -109,23 +109,28 @@ abstract class AphrontResponse {
     if ($this->cacheable) {
       $headers[] = array(
         'Expires',
-        $this->formatEpochTimestampForHTTPHeader(time() + $this->cacheable));
+        $this->formatEpochTimestampForHTTPHeader(time() + $this->cacheable),
+      );
     } else {
       $headers[] = array(
         'Cache-Control',
-        'private, no-cache, no-store, must-revalidate');
+        'private, no-cache, no-store, must-revalidate',
+      );
       $headers[] = array(
         'Pragma',
-        'no-cache');
+        'no-cache',
+      );
       $headers[] = array(
         'Expires',
-        'Sat, 01 Jan 2000 00:00:00 GMT');
+        'Sat, 01 Jan 2000 00:00:00 GMT',
+      );
     }
 
     if ($this->lastModified) {
       $headers[] = array(
         'Last-Modified',
-        $this->formatEpochTimestampForHTTPHeader($this->lastModified));
+        $this->formatEpochTimestampForHTTPHeader($this->lastModified),
+      );
     }
 
     // IE has a feature where it may override an explicit Content-Type

src/applications/audit/query/PhabricatorCommitSearchEngine.php

@@ -82,7 +82,8 @@ final class PhabricatorCommitSearchEngine
       array(
         $auditor_phids,
         $commit_author_phids,
-        $repository_phids));
+        $repository_phids,
+      ));
 
     $handles = id(new PhabricatorHandleQuery())
       ->setViewer($this->requireViewer())

src/applications/auth/controller/PhabricatorAuthValidateController.php

@@ -22,7 +22,8 @@ final class PhabricatorAuthValidateController
         array(
           pht(
             'Login validation is missing expected parameter ("%s").',
-            'phusr')));
+            'phusr'),
+        ));
     }
 
     $expect_phusr = $request->getStr('expect');

src/applications/auth/provider/PhabricatorAuthProvider.php

@@ -243,7 +243,7 @@ abstract class PhabricatorAuthProvider {
             $image_uri,
             array(
               'name' => $name,
-              'canCDN' => true
+              'canCDN' => true,
             ));
         unset($unguarded);
 

src/applications/calendar/__tests__/CalendarTimeUtilTestCase.php

@@ -55,7 +55,8 @@ final class CalendarTimeUtilTestCase extends PhabricatorTestCase {
       'Wednesday',
       'Thursday',
       'Friday',
-      'Saturday');
+      'Saturday',
+    );
   }
 
 }

src/applications/calendar/controller/PhabricatorCalendarViewController.php

@@ -103,7 +103,8 @@ final class PhabricatorCalendarViewController
             phutil_tag(
               'a',
               array(
-                'href' => $login_uri),
+                'href' => $login_uri,
+              ),
               pht('Log in'))));
     }
 

src/applications/calendar/util/CalendarTimeUtil.php

@@ -24,7 +24,8 @@ final class CalendarTimeUtil {
 
     return array(
       'start_epoch' => $start_day->format('U'),
-      'end_epoch' => $end_day->format('U'));
+      'end_epoch' => $end_day->format('U'),
+    );
   }
 
   public static function getCalendarWeekTimestamps(
@@ -56,7 +57,8 @@ final class CalendarTimeUtil {
     }
     return array(
       'today' => $objects['today'],
-      'epoch_stamps' => $timestamps);
+      'epoch_stamps' => $timestamps,
+    );
   }
 
   private static function getStartDateTimeObjects(
@@ -80,7 +82,8 @@ final class CalendarTimeUtil {
     }
     return array(
       'today' => $today,
-      'start_day' => $start_day);
+      'start_day' => $start_day,
+    );
   }
 
 }

src/applications/chatlog/controller/PhabricatorChatLogChannelLogController.php

@@ -120,7 +120,7 @@ final class PhabricatorChatLogChannelLogController
         'a',
           array(
             'href' => $href,
-            'class' => 'timestamp'
+            'class' => 'timestamp',
           ),
         $timestamp);
 
@@ -129,11 +129,12 @@ final class PhabricatorChatLogChannelLogController
       $message = phutil_tag(
         'td',
           array(
-            'class' => 'message'
+            'class' => 'message',
           ),
           array(
             $timestamp,
-            $message));
+            $message,
+          ));
 
       $out[] = phutil_tag(
         'tr',
@@ -142,7 +143,8 @@ final class PhabricatorChatLogChannelLogController
         ),
         array(
           $author,
-          $message));
+          $message,
+        ));
     }
 
     $links = array();
@@ -210,41 +212,41 @@ final class PhabricatorChatLogChannelLogController
     $table = phutil_tag(
       'table',
         array(
-          'class' => 'phabricator-chat-log'
+          'class' => 'phabricator-chat-log',
         ),
       $out);
 
     $log = phutil_tag(
       'div',
         array(
-          'class' => 'phabricator-chat-log-panel'
+          'class' => 'phabricator-chat-log-panel',
         ),
         $table);
 
     $jump_link = phutil_tag(
       'a',
         array(
-          'href' => '#latest'
+          'href' => '#latest',
         ),
         pht('Jump to Bottom')." \xE2\x96\xBE");
 
     $jump = phutil_tag(
       'div',
         array(
-          'class' => 'phabricator-chat-log-jump'
+          'class' => 'phabricator-chat-log-jump',
         ),
         $jump_link);
 
     $jump_target = phutil_tag(
       'div',
         array(
-          'id' => 'latest'
+          'id' => 'latest',
         ));
 
     $content = phutil_tag(
       'div',
         array(
-          'class' => 'phabricator-chat-log-wrap'
+          'class' => 'phabricator-chat-log-wrap',
         ),
         array(
           $jump,

src/applications/conduit/controller/PhabricatorConduitAPIController.php

@@ -279,7 +279,7 @@ final class PhabricatorConduitAPIController
     if (!$session_key) {
       return array(
         'ERR-INVALID-SESSION',
-        'Session key is not present.'
+        'Session key is not present.',
       );
     }
 

src/applications/config/check/PhabricatorSetupCheckDaemons.php

@@ -31,7 +31,7 @@ final class PhabricatorSetupCheckDaemons extends PhabricatorSetupCheck {
           'a',
           array(
             'href' => $doc_href,
-            'target' => '_blank'
+            'target' => '_blank',
           ),
           pht('Managing Daemons with phd')));
 
@@ -100,14 +100,14 @@ final class PhabricatorSetupCheckDaemons extends PhabricatorSetupCheck {
             'a',
             array(
               'href' => '/daemon/',
-              'target' => '_blank'
+              'target' => '_blank',
             ),
             pht('Daemon Console')),
           phutil_tag(
             'a',
             array(
               'href' => $doc_href,
-              'target' => '_blank'
+              'target' => '_blank',
             ),
             pht('Managing Daemons with phd')),
           phutil_tag('tt', array(), 'PHABRICATOR_ENV'),

src/applications/config/controller/PhabricatorConfigDatabaseIssueController.php

@@ -25,7 +25,8 @@ final class PhabricatorConfigDatabaseIssueController
           null,
           null,
           null,
-          $issue);
+          $issue,
+        );
       }
       foreach ($database->getTables() as $table_name => $table) {
         foreach ($table->getLocalIssues() as $issue) {
@@ -34,7 +35,8 @@ final class PhabricatorConfigDatabaseIssueController
             $table_name,
             null,
             null,
-            $issue);
+            $issue,
+          );
         }
         foreach ($table->getColumns() as $column_name => $column) {
           foreach ($column->getLocalIssues() as $issue) {
@@ -43,7 +45,8 @@ final class PhabricatorConfigDatabaseIssueController
               $table_name,
               'column',
               $column_name,
-              $issue);
+              $issue,
+            );
           }
         }
         foreach ($table->getKeys() as $key_name => $key) {
@@ -53,7 +56,8 @@ final class PhabricatorConfigDatabaseIssueController
               $table_name,
               'key',
               $key_name,
-              $issue);
+              $issue,
+            );
           }
         }
       }

src/applications/config/controller/PhabricatorConfigDatabaseStatusController.php

@@ -372,7 +372,7 @@ final class PhabricatorConfigDatabaseStatusController
           null,
           null,
           null,
-          null
+          null,
         ));
 
     $key_rows = array();

src/applications/config/controller/PhabricatorConfigListController.php

@@ -21,7 +21,7 @@ final class PhabricatorConfigListController
 
     $nav->appendChild(
       array(
-        $box
+        $box,
       ));
 
     $crumbs = $this

src/applications/config/editor/PhabricatorConfigEditor.php

@@ -122,7 +122,7 @@ final class PhabricatorConfigEditor
       ->setNewValue(
         array(
            'deleted' => false,
-           'value' => $value
+           'value' => $value,
         ));
 
     $editor = id(new PhabricatorConfigEditor())

src/applications/config/option/PhabricatorAuthenticationConfigOptions.php

@@ -17,7 +17,7 @@ final class PhabricatorAuthenticationConfigOptions
         ->setBoolOptions(
           array(
             pht('Require email verification'),
-            pht("Don't require email verification")
+            pht("Don't require email verification"),
           ))
         ->setSummary(
           pht('Require email verification before a user can log in.'))
@@ -77,7 +77,7 @@ final class PhabricatorAuthenticationConfigOptions
         ->setBoolOptions(
           array(
             pht('Allow editing'),
-            pht('Prevent editing')
+            pht('Prevent editing'),
           ))
         ->setSummary(
           pht(

src/applications/config/option/PhabricatorCoreConfigOptions.php

@@ -94,7 +94,7 @@ final class PhabricatorCoreConfigOptions
         ->setBoolOptions(
           array(
             pht('Enable Prototypes'),
-            pht('Disable Prototypes')
+            pht('Disable Prototypes'),
           ))
         ->setSummary(
           pht(

src/applications/config/option/PhabricatorGarbageCollectorConfigOptions.php

@@ -16,25 +16,32 @@ final class PhabricatorGarbageCollectorConfigOptions
     $options = array(
       'gcdaemon.ttl.herald-transcripts' => array(
         30,
-        pht('Number of seconds to retain Herald transcripts for.')),
+        pht('Number of seconds to retain Herald transcripts for.'),
+      ),
       'gcdaemon.ttl.daemon-logs' => array(
         7,
-        pht('Number of seconds to retain Daemon logs for.')),
+        pht('Number of seconds to retain Daemon logs for.'),
+      ),
       'gcdaemon.ttl.differential-parse-cache' => array(
         14,
-        pht('Number of seconds to retain Differential parse caches for.')),
+        pht('Number of seconds to retain Differential parse caches for.'),
+      ),
       'gcdaemon.ttl.markup-cache' => array(
         30,
-        pht('Number of seconds to retain Markup cache entries for.')),
+        pht('Number of seconds to retain Markup cache entries for.'),
+      ),
       'gcdaemon.ttl.task-archive' => array(
         14,
-        pht('Number of seconds to retain archived background tasks for.')),
+        pht('Number of seconds to retain archived background tasks for.'),
+      ),
       'gcdaemon.ttl.general-cache' => array(
         30,
-        pht('Number of seconds to retain general cache entries for.')),
+        pht('Number of seconds to retain general cache entries for.'),
+      ),
       'gcdaemon.ttl.conduit-logs' => array(
         180,
-        pht('Number of seconds to retain Conduit call logs for.'))
+        pht('Number of seconds to retain Conduit call logs for.'),
+      ),
     );
 
     $result = array();

src/applications/config/option/PhabricatorSMSConfigOptions.php

@@ -48,7 +48,7 @@ EODOC
         ->setDescription(pht('Authorization token from Twilio service.'))
         ->setLocked(true)
         ->setHidden(true)
-        ->addExample('f3jsi4i67wiwt6w54hf2zwvy3fjf5h', pht('30 characters'))
+        ->addExample('f3jsi4i67wiwt6w54hf2zwvy3fjf5h', pht('30 characters')),
     );
   }
 

src/applications/conpherence/conduit/ConpherenceCreateThreadConduitAPIMethod.php

@@ -15,7 +15,7 @@ final class ConpherenceCreateThreadConduitAPIMethod
     return array(
       'title' => 'optional string',
       'message' => 'required string',
-      'participantPHIDs' => 'required list<phids>'
+      'participantPHIDs' => 'required list<phids>',
     );
   }
 
@@ -28,7 +28,7 @@ final class ConpherenceCreateThreadConduitAPIMethod
       'ERR_EMPTY_PARTICIPANT_PHIDS' => pht(
         'You must specify participant phids.'),
       'ERR_EMPTY_MESSAGE' => pht(
-        'You must specify a message.')
+        'You must specify a message.'),
     );
   }
 

src/applications/conpherence/conduit/ConpherenceQueryThreadConduitAPIMethod.php

@@ -20,7 +20,7 @@ final class ConpherenceQueryThreadConduitAPIMethod
       'ids' => 'optional array<int>',
       'phids' => 'optional array<phids>',
       'limit' => 'optional int',
-      'offset' => 'optional int'
+      'offset' => 'optional int',
     );
   }
 
@@ -78,7 +78,8 @@ final class ConpherenceQueryThreadConduitAPIMethod
         'messageCount' => $conpherence->getMessageCount(),
         'recentParticipantPHIDs' => $conpherence->getRecentParticipantPHIDs(),
         'filePHIDs' => $conpherence->getFilePHIDs(),
-        'conpherenceURI' => $this->getConpherenceURI($conpherence));
+        'conpherenceURI' => $this->getConpherenceURI($conpherence),
+      );
     }
     return $data;
   }

src/applications/conpherence/conduit/ConpherenceQueryTransactionConduitAPIMethod.php

@@ -20,7 +20,7 @@ final class ConpherenceQueryTransactionConduitAPIMethod
       'threadID' => 'optional int',
       'threadPHID' => 'optional phid',
       'limit' => 'optional int',
-      'offset' => 'optional int'
+      'offset' => 'optional int',
     );
   }
 
@@ -32,7 +32,7 @@ final class ConpherenceQueryTransactionConduitAPIMethod
     return array(
       'ERR_USAGE_NO_THREAD_ID' => pht(
         'You must specify a thread id or thread phid to query transactions '.
-        'from.')
+        'from.'),
     );
   }
 
@@ -88,7 +88,8 @@ final class ConpherenceQueryTransactionConduitAPIMethod
         'authorPHID' => $transaction->getAuthorPHID(),
         'dateCreated' => $transaction->getDateCreated(),
         'conpherenceID' => $conpherence->getID(),
-        'conpherencePHID' => $conpherence->getPHID());
+        'conpherencePHID' => $conpherence->getPHID(),
+      );
     }
     return $data;
   }

src/applications/conpherence/conduit/ConpherenceUpdateThreadConduitAPIMethod.php

@@ -18,7 +18,7 @@ final class ConpherenceUpdateThreadConduitAPIMethod
       'title' => 'optional string',
       'message' => 'optional string',
       'addParticipantPHIDs' => 'optional list<phids>',
-      'removeParticipantPHID' => 'optional phid'
+      'removeParticipantPHID' => 'optional phid',
     );
   }
 
@@ -36,7 +36,7 @@ final class ConpherenceUpdateThreadConduitAPIMethod
       'ERR_USAGE_ONLY_SELF_REMOVE' => pht(
         'Only a user can remove themselves from a thread.'),
       'ERR_USAGE_NO_UPDATES' => pht(
-        'You must specify data that actually updates the conpherence.')
+        'You must specify data that actually updates the conpherence.'),
     );
   }
 

src/applications/conpherence/controller/ConpherenceController.php

@@ -70,10 +70,11 @@ abstract class ConpherenceController extends PhabricatorController {
         phutil_tag(
           'div',
           array(
-            'class' => 'header-loading-mask'
+            'class' => 'header-loading-mask',
           ),
           ''),
-        $crumbs));
+        $crumbs,
+      ));
   }
 
   protected function renderConpherenceTransactions(

src/applications/conpherence/controller/ConpherenceListController.php

@@ -140,7 +140,8 @@ final class ConpherenceListController extends ConpherenceController {
         $phids = array_keys($participation);
         $content = array(
           'html' => $thread_html,
-          'phids' => $phids);
+          'phids' => $phids,
+        );
         $response = id(new AphrontAjaxResponse())->setContent($content);
         break;
       case self::UNSELECTED_MODE:

src/applications/conpherence/controller/ConpherenceViewController.php

@@ -72,7 +72,7 @@ final class ConpherenceViewController extends
       $content = array(
         'header' => $header,
         'messages' => $messages,
-        'form' => $form
+        'form' => $form,
       );
     }
 
@@ -114,8 +114,8 @@ final class ConpherenceViewController extends
           'sigil' => 'show-older-messages',
           'class' => 'conpherence-show-older-messages',
           'meta' => array(
-            'oldest_transaction_id' => $oldest_transaction_id
+            'oldest_transaction_id' => $oldest_transaction_id,
-          )
+          ),
         ),
         pht('Show Older Messages'));
     }

src/applications/conpherence/controller/ConpherenceWidgetController.php

@@ -100,7 +100,7 @@ final class ConpherenceWidgetController extends ConpherenceController {
         'class' => 'widgets-body',
         'id' => 'widgets-files',
         'sigil' => 'widgets-files',
-        'style' => 'display: none;'
+        'style' => 'display: none;',
       ),
       id(new ConpherenceFileWidgetView())
       ->setUser($user)
@@ -111,7 +111,7 @@ final class ConpherenceWidgetController extends ConpherenceController {
       array(
         'class' => 'widgets-body',
         'id' => 'widgets-calendar',
-        'style' => 'display: none;'
+        'style' => 'display: none;',
       ),
       $this->renderCalendarWidgetPaneContent());
     $widgets[] = phutil_tag(
@@ -119,7 +119,7 @@ final class ConpherenceWidgetController extends ConpherenceController {
       array(
         'class' => 'widgets-body',
         'id' => 'widgets-settings',
-        'style' => 'display: none'
+        'style' => 'display: none',
       ),
       $this->renderSettingsWidgetPaneContent());
 
@@ -166,7 +166,7 @@ final class ConpherenceWidgetController extends ConpherenceController {
         array(
           'type' => 'hidden',
           'name' => 'action',
-          'value' => 'notifications'
+          'value' => 'notifications',
         )),
       phutil_tag(
         'button',
@@ -174,7 +174,7 @@ final class ConpherenceWidgetController extends ConpherenceController {
           'type' => 'submit',
           'class' => 'notifications-update',
         ),
-        pht('Save'))
+        pht('Save')),
     );
 
     return phabricator_form(
@@ -222,21 +222,22 @@ final class ConpherenceWidgetController extends ConpherenceController {
         $content[] = phutil_tag(
           'div',
           array(
-            'class' => 'day-header '.$active_class
+            'class' => 'day-header '.$active_class,
           ),
           array(
             phutil_tag(
               'div',
               array(
-                'class' => 'day-name'
+                'class' => 'day-name',
               ),
               $day->format('l')),
             phutil_tag(
               'div',
               array(
-                'class' => 'day-date'
+                'class' => 'day-date',
               ),
-              $day->format('m/d/y'))));
+              $day->format('m/d/y')),
+          ));
       }
 
       $week_day_number = $day->format('w');
@@ -298,16 +299,18 @@ final class ConpherenceWidgetController extends ConpherenceController {
                 phutil_tag(
                   'div',
                   array(
-                    'class' => 'description'
+                    'class' => 'description',
                   ),
                   array(
                     $status->getTerseSummary($user),
                     phutil_tag(
                       'div',
                       array(
-                        'class' => 'participant'
+                        'class' => 'participant',
                       ),
-                      $secondary_info)))));
+                      $secondary_info),
+                  )),
+              ));
           }
           $first_status_of_the_day = false;
         }
@@ -332,14 +335,14 @@ final class ConpherenceWidgetController extends ConpherenceController {
             $inner_layout[] = phutil_tag(
               'div',
               array(
-                'class' => $status->getTextStatus()
+                'class' => $status->getTextStatus(),
               ),
               '');
           } else {
             $inner_layout[] = phutil_tag(
               'div',
               array(
-                'class' => 'present'
+                'class' => 'present',
               ),
               '');
           }
@@ -348,13 +351,13 @@ final class ConpherenceWidgetController extends ConpherenceController {
           phutil_tag(
             'div',
             array(
-              'class' => 'day-column'.$active_class
+              'class' => 'day-column'.$active_class,
             ),
             array(
               phutil_tag(
                 'div',
                 array(
-                  'class' => 'day-name'
+                  'class' => 'day-name',
                 ),
                 $day->format('D')),
               phutil_tag(
@@ -363,17 +366,16 @@ final class ConpherenceWidgetController extends ConpherenceController {
                   'class' => 'day-number',
                 ),
                 $day->format('j')),
-              $inner_layout
+              $inner_layout,
             )));
         $calendar_columns++;
       }
     }
 
-    return
+    return array(
-      array(
+      $layout,
-        $layout,
+      $content,
-        $content
+    );
-      );
   }
 
   private function getWidgetURI() {

src/applications/conpherence/query/ConpherenceThreadQuery.php

@@ -279,7 +279,7 @@ final class ConpherenceThreadQuery
       $widget_data = array(
         'statuses' => $statuses,
         'files' => $conpherence_files,
-        'files_authors' => $files_authors
+        'files_authors' => $files_authors,
       );
       $conpherence->attachWidgetData($widget_data);
     }

src/applications/conpherence/view/ConpherenceFileWidgetView.php

@@ -15,7 +15,7 @@ final class ConpherenceFileWidgetView extends ConpherenceWidgetView {
       $icon_view = phutil_tag(
         'div',
         array(
-          'class' => 'file-icon sprite-docs '.$icon_class
+          'class' => 'file-icon sprite-docs '.$icon_class,
         ),
         '');
       $file_view = id(new PhabricatorFileLinkView())
@@ -41,19 +41,19 @@ final class ConpherenceFileWidgetView extends ConpherenceWidgetView {
       $who_done_it = phutil_tag(
         'div',
         array(
-          'class' => 'file-uploaded-by'
+          'class' => 'file-uploaded-by',
         ),
         pht('%s%s.', $who_done_it_text, $date_text));
 
       $files_html[] = phutil_tag(
         'div',
         array(
-          'class' => 'file-entry'
+          'class' => 'file-entry',
         ),
         array(
           $icon_view,
           $file_view,
-          $who_done_it
+          $who_done_it,
         ));
     }
 
@@ -62,7 +62,8 @@ final class ConpherenceFileWidgetView extends ConpherenceWidgetView {
         'div',
         array(
           'class' => 'no-files',
-          'sigil' => 'no-files'),
+          'sigil' => 'no-files',
+        ),
         pht('No files.'));
     }
 

src/applications/conpherence/view/ConpherenceLayoutView.php

@@ -83,7 +83,7 @@ final class ConpherenceLayoutView extends AphrontView {
             'name' => pht('Thread'),
             'icon' => 'fa-comment',
             'deviceOnly' => true,
-            'hasCreate' => false
+            'hasCreate' => false,
           ),
           'widgets-people' => array(
             'name' => pht('Participants'),
@@ -93,14 +93,14 @@ final class ConpherenceLayoutView extends AphrontView {
             'createData' => array(
               'refreshFromResponse' => true,
               'action' => ConpherenceUpdateActions::ADD_PERSON,
-              'customHref' => null
+              'customHref' => null,
-            )
+            ),
           ),
           'widgets-files' => array(
             'name' => pht('Files'),
             'icon' => 'fa-files-o',
             'deviceOnly' => false,
-            'hasCreate' => false
+            'hasCreate' => false,
           ),
           'widgets-calendar' => array(
             'name' => pht('Calendar'),
@@ -110,16 +110,17 @@ final class ConpherenceLayoutView extends AphrontView {
             'createData' => array(
               'refreshFromResponse' => false,
               'action' => ConpherenceUpdateActions::ADD_STATUS,
-              'customHref' => '/calendar/event/create/'
+              'customHref' => '/calendar/event/create/',
-            )
+            ),
           ),
           'widgets-settings' => array(
             'name' => pht('Settings'),
             'icon' => 'fa-wrench',
             'deviceOnly' => false,
-            'hasCreate' => false
+            'hasCreate' => false,
           ),
-        )));
+        ),
+      ));
 
 
     return javelin_tag(
@@ -170,7 +171,7 @@ final class ConpherenceLayoutView extends AphrontView {
                 phutil_tag(
                   'div',
                   array(
-                    'class' => 'text'
+                    'class' => 'text',
                   ),
                   pht('You do not have any messages yet.')),
                 javelin_tag(
@@ -180,7 +181,7 @@ final class ConpherenceLayoutView extends AphrontView {
                     'class' => 'button grey',
                     'sigil' => 'workflow',
                   ),
-                  pht('Send a Message'))
+                  pht('Send a Message')),
             )),
             javelin_tag(
               'div',
@@ -193,21 +194,22 @@ final class ConpherenceLayoutView extends AphrontView {
                 phutil_tag(
                   'div',
                   array(
-                    'class' => 'widgets-loading-mask'
+                    'class' => 'widgets-loading-mask',
                   ),
                   ''),
                 javelin_tag(
                   'div',
                   array(
-                    'sigil' => 'conpherence-widgets-holder'
+                    'sigil' => 'conpherence-widgets-holder',
                   ),
-                  ''))),
+                  ''),
+              )),
             javelin_tag(
               'div',
               array(
                 'class' => 'conpherence-message-pane',
                 'id' => 'conpherence-message-pane',
-                'sigil' => 'conpherence-message-pane'
+                'sigil' => 'conpherence-message-pane',
               ),
               array(
                 javelin_tag(
@@ -228,9 +230,9 @@ final class ConpherenceLayoutView extends AphrontView {
                   'div',
                   array(
                     'id' => 'conpherence-form',
-                    'sigil' => 'conpherence-form'
+                    'sigil' => 'conpherence-form',
                   ),
-                  nonempty($this->replyForm, ''))
+                  nonempty($this->replyForm, '')),
               )),
           )),
       ));

src/applications/conpherence/view/ConpherenceMenuItemView.php

@@ -77,7 +77,7 @@ final class ConpherenceMenuItemView extends AphrontTagView {
         'span',
         array(
           'class' => 'conpherence-menu-item-image',
-          'style' => 'background-image: url('.$this->imageURI.');'
+          'style' => 'background-image: url('.$this->imageURI.');',
         ),
         '');
     }
@@ -104,7 +104,7 @@ final class ConpherenceMenuItemView extends AphrontTagView {
       $unread_count = phutil_tag(
         'span',
         array(
-          'class' => 'conpherence-menu-item-unread-count'
+          'class' => 'conpherence-menu-item-unread-count',
         ),
         (int)$this->unreadCount);
     }

src/applications/conpherence/view/ConpherencePeopleWidgetView.php

@@ -25,14 +25,14 @@ final class ConpherencePeopleWidgetView extends ConpherenceWidgetView {
             'meta' => array(
               'remove_person' => $handle->getPHID(),
               'action' => 'remove_person',
-            )
+            ),
           ),
           hsprintf('<span class="close-icon">&times;</span>'));
       }
       $body[] = phutil_tag(
         'div',
         array(
-          'class' => 'person-entry grouped'
+          'class' => 'person-entry grouped',
         ),
         array(
           phutil_tag(
@@ -43,11 +43,12 @@ final class ConpherencePeopleWidgetView extends ConpherenceWidgetView {
             phutil_tag(
               'img',
               array(
-                'src' => $handle->getImageURI()
+                'src' => $handle->getImageURI(),
               ),
               '')),
           $handle->renderLink(),
-          $remove_html));
+          $remove_html,
+        ));
     }
 
     return $body;

src/applications/conpherence/view/ConpherenceThreadListView.php

@@ -148,7 +148,8 @@ final class ConpherenceThreadListView extends AphrontView {
         'participant_id' => $participant->getID(),
         'conpherence_phid' => $participant->getConpherencePHID(),
         'date_touched' => $participant->getDateTouched(),
-        'direction' => $direction));
+        'direction' => $direction,
+      ));
     return $item;
   }
 
@@ -156,7 +157,7 @@ final class ConpherenceThreadListView extends AphrontView {
     $message = phutil_tag(
       'div',
       array(
-        'class' => 'no-conpherences-menu-item'
+        'class' => 'no-conpherences-menu-item',
       ),
       pht('No conpherences.'));
 

src/applications/conpherence/view/ConpherenceTransactionView.php

@@ -38,7 +38,7 @@ final class ConpherenceTransactionView extends AphrontView {
         return phutil_tag(
           'div',
           array(
-            'class' => 'date-marker'
+            'class' => 'date-marker',
           ),
           array(
             phutil_tag(
@@ -49,7 +49,8 @@ final class ConpherenceTransactionView extends AphrontView {
               phabricator_format_local_time(
                 $transaction->getDateCreated(),
                 $user,
-              'M jS, Y'))));
+              'M jS, Y')),
+          ));
         break;
     }
 
@@ -92,7 +93,7 @@ final class ConpherenceTransactionView extends AphrontView {
       phutil_tag(
         'div',
         array(
-          'class' => $content_class
+          'class' => $content_class,
         ),
         $content));
 

src/applications/countdown/application/PhabricatorCountdownApplication.php

@@ -43,7 +43,7 @@ final class PhabricatorCountdownApplication extends PhabricatorApplication {
           => 'PhabricatorCountdownListController',
         '(?P<id>[1-9]\d*)/' => 'PhabricatorCountdownViewController',
         'edit/(?:(?P<id>[1-9]\d*)/)?' => 'PhabricatorCountdownEditController',
-        'delete/(?P<id>[1-9]\d*)/' => 'PhabricatorCountdownDeleteController'
+        'delete/(?P<id>[1-9]\d*)/' => 'PhabricatorCountdownDeleteController',
       ),
     );
   }

src/applications/dashboard/controller/PhabricatorDashboardInstallController.php

@@ -52,7 +52,8 @@ final class PhabricatorDashboardInstallController
 
     $handles = $this->loadHandles(array(
       $object_phid,
-      $installer_phid));
+      $installer_phid,
+    ));
 
     if ($request->isFormPost()) {
       $dashboard_install = id(new PhabricatorDashboardInstall())

src/applications/dashboard/customfield/PhabricatorDashboardPanelSearchQueryCustomField.php

@@ -52,8 +52,8 @@ final class PhabricatorDashboardPanelSearchQueryCustomField
         'options' => $queries,
         'value' => array(
           'key' => strlen($value) ? $value : null,
-          'name' => $name
+          'name' => $name,
-        )
+        ),
       ));
 
     return id(new AphrontFormSelectControl())

src/applications/dashboard/engine/PhabricatorDashboardPanelRenderingEngine.php

@@ -193,11 +193,14 @@ final class PhabricatorDashboardPanelRenderingEngine extends Phobject {
         'id' => $id,
         'sigil' => 'dashboard-panel',
         'meta' => array(
-          'objectPHID' => $panel->getPHID()),
+          'objectPHID' => $panel->getPHID(),
-        'class' => 'dashboard-panel'),
+        ),
+        'class' => 'dashboard-panel',
+      ),
       array(
         $header,
-        $content));
+        $content,
+      ));
   }
 
 

src/applications/dashboard/layoutconfig/PhabricatorDashboardLayoutConfig.php

@@ -120,7 +120,8 @@ final class PhabricatorDashboardLayoutConfig {
       case self::MODE_THIRDS_AND_THIRD:
         return array(
           0 => pht('Left'),
-          1 => pht('Right'));
+          1 => pht('Right'),
+        );
         break;
       case self::MODE_FULL:
         throw new Exception('There is only one column in mode full.');
@@ -156,7 +157,7 @@ final class PhabricatorDashboardLayoutConfig {
   public function toDictionary() {
     return array(
       'layoutMode' => $this->getLayoutMode(),
-      'panelLocations' => $this->getPanelLocations()
+      'panelLocations' => $this->getPanelLocations(),
     );
   }
 

src/applications/dashboard/query/PhabricatorDashboardSearchEngine.php

@@ -60,8 +60,10 @@ final class PhabricatorDashboardSearchEngine
       $installs = id(new PhabricatorDashboardInstall())
         ->loadAllWhere(
           'objectPHID IN (%Ls) AND dashboardPHID IN (%Ls)',
-          array(PhabricatorHomeApplication::DASHBOARD_DEFAULT,
+          array(
-                $viewer->getPHID()),
+            PhabricatorHomeApplication::DASHBOARD_DEFAULT,
+            $viewer->getPHID(),
+          ),
           array_keys($dashboards));
       $installs = mpull($installs, null, 'getDashboardPHID');
     } else {
@@ -87,12 +89,14 @@ final class PhabricatorDashboardSearchEngine
         if ($install->getObjectPHID() == $viewer->getPHID()) {
           $attrs = array(
             'tip' => pht(
-              'This dashboard is installed to your personal homepage.'));
+              'This dashboard is installed to your personal homepage.'),
+          );
           $item->addIcon('fa-user', pht('Installed'), $attrs);
         } else {
           $attrs = array(
             'tip' => pht(
-              'This dashboard is the default homepage for all users.'));
+              'This dashboard is the default homepage for all users.'),
+          );
           $item->addIcon('fa-globe', pht('Installed'), $attrs);
         }
       }

src/applications/differential/conduit/DifferentialCreateInlineConduitAPIMethod.php

@@ -33,7 +33,7 @@ final class DifferentialCreateInlineConduitAPIMethod
       'ERR-BAD-DIFF'     => 'Bad diff ID, or diff does not belong to revision.',
       'ERR-NEED-DIFF'    => 'Neither revision ID nor diff ID was provided.',
       'ERR-NEED-FILE'    => 'A file path was not provided.',
-      'ERR-BAD-FILE'     => "Requested file doesn't exist in this revision."
+      'ERR-BAD-FILE'     => "Requested file doesn't exist in this revision.",
     );
   }
 

src/applications/differential/conduit/DifferentialFinishPostponedLintersConduitAPIMethod.php

@@ -101,7 +101,8 @@ final class DifferentialFinishPostponedLintersConduitAPIMethod
       array(
         'diff_id' => $diff_id,
         'name' => 'arc:lint',
-        'data' => json_encode($messages)));
+        'data' => json_encode($messages),
+      ));
     $call->setForceLocal(true);
     $call->setUser($request->getUser());
     $call->execute();
@@ -110,7 +111,8 @@ final class DifferentialFinishPostponedLintersConduitAPIMethod
       array(
         'diff_id' => $diff_id,
         'name' => 'arc:lint-postponed',
-        'data' => json_encode($postponed_linters)));
+        'data' => json_encode($postponed_linters),
+      ));
     $call->setForceLocal(true);
     $call->setUser($request->getUser());
     $call->execute();

src/applications/differential/conduit/DifferentialGetRevisionConduitAPIMethod.php

@@ -94,7 +94,7 @@ final class DifferentialGetRevisionConduitAPIMethod
       'reviewerPHIDs' => $reviewer_phids,
       'diffs' => $diff_dicts,
       'commits' => $commit_dicts,
-      'auxiliary' => idx($field_data, $revision->getPHID(), array())
+      'auxiliary' => idx($field_data, $revision->getPHID(), array()),
     );
 
     return $dict;

src/applications/differential/conduit/DifferentialUpdateUnitResultsConduitAPIMethod.php

@@ -115,7 +115,8 @@ final class DifferentialUpdateUnitResultsConduitAPIMethod
         DifferentialUnitTestResult::RESULT_SKIP =>
           DifferentialUnitStatus::UNIT_OKAY,
         DifferentialUnitTestResult::RESULT_POSTPONED =>
-          DifferentialUnitStatus::UNIT_POSTPONED);
+          DifferentialUnitStatus::UNIT_POSTPONED,
+      );
 
     // These are the relative priorities for the unit test results
     $status_codes_priority =
@@ -123,7 +124,8 @@ final class DifferentialUpdateUnitResultsConduitAPIMethod
         DifferentialUnitStatus::UNIT_OKAY => 1,
         DifferentialUnitStatus::UNIT_WARN => 2,
         DifferentialUnitStatus::UNIT_POSTPONED => 3,
-        DifferentialUnitStatus::UNIT_FAIL => 4);
+        DifferentialUnitStatus::UNIT_FAIL => 4,
+      );
 
     // Walk the now-current list of status codes to find the overall diff
     // status

src/applications/differential/controller/DifferentialRevisionLandController.php

@@ -145,8 +145,8 @@ final class DifferentialRevisionLandController extends DifferentialController {
     $looksoon = new ConduitCall(
       'diffusion.looksoon',
       array(
-        'callsigns' => array($repository->getCallsign())
+        'callsigns' => array($repository->getCallsign()),
-        ));
+      ));
     $looksoon->setUser($request->getUser());
     $looksoon->execute();
 

src/applications/differential/render/DifferentialChangesetHTMLRenderer.php

@@ -328,7 +328,7 @@ abstract class DifferentialChangesetHTMLRenderer
         $row = array(
           $readable_key,
           $oval,
-          $nval
+          $nval,
         );
         $rows[] = $row;
 

src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php

@@ -25,7 +25,7 @@ final class DifferentialChangesetTwoUpRenderer
           'td',
           array(
             'colspan' => 6,
-            'class' => 'show-more'
+            'class' => 'show-more',
           ),
           pht('Context not available.')));
     }
@@ -302,7 +302,7 @@ final class DifferentialChangesetTwoUpRenderer
           array('class' => $n_classes, 'colspan' => $n_colspan),
           array(
             phutil_tag('span', array('class' => 'zwsp'), $zero_space),
-            $n_text
+            $n_text,
           )),
         $n_cov,
       ));
@@ -365,7 +365,7 @@ final class DifferentialChangesetTwoUpRenderer
       $old = phutil_tag(
         'div',
         array(
-          'class' => 'differential-image-stage'
+          'class' => 'differential-image-stage',
         ),
         phutil_tag(
           'img',
@@ -379,7 +379,7 @@ final class DifferentialChangesetTwoUpRenderer
       $new = phutil_tag(
         'div',
         array(
-          'class' => 'differential-image-stage'
+          'class' => 'differential-image-stage',
         ),
         phutil_tag(
           'img',

src/applications/differential/storage/DifferentialDiff.php

@@ -229,7 +229,7 @@ final class DifferentialDiff
       'lintStatus' => $this->getLintStatus(),
       'changes' => array(),
       'properties' => array(),
-      'projectName' => $this->getArcanistProjectName()
+      'projectName' => $this->getArcanistProjectName(),
     );
 
     $dict['changes'] = $this->buildChangesList();

src/applications/differential/view/DifferentialChangesetDetailView.php

@@ -215,7 +215,8 @@ final class DifferentialChangesetDetailView extends AphrontView {
         $buttons,
         phutil_tag('h1',
           array(
-            'class' => 'differential-file-icon-header'),
+            'class' => 'differential-file-icon-header',
+          ),
           array(
             $icon,
             $display_filename,

src/applications/differential/view/DifferentialChangesetListView.php

@@ -110,8 +110,9 @@ final class DifferentialChangesetListView extends AphrontView {
     Javelin::initBehavior('differential-toggle-files', array(
       'pht' => array(
         'undo' => pht('Undo'),
-        'collapsed' => pht('This file content has been collapsed.'))
+        'collapsed' => pht('This file content has been collapsed.'),
-      ));
+      ),
+    ));
     Javelin::initBehavior(
       'differential-dropdown-menus',
       array(

src/applications/differential/view/DifferentialDiffTableOfContentsView.php

@@ -160,7 +160,7 @@ final class DifferentialDiffTableOfContentsView extends AphrontView {
         $meta = phutil_tag(
           'div',
           array(
-            'class' => 'differential-toc-meta'
+            'class' => 'differential-toc-meta',
           ),
           $meta);
       }
@@ -176,7 +176,7 @@ final class DifferentialDiffTableOfContentsView extends AphrontView {
         $desc,
         array($link, $lines, $meta),
         $cov,
-        $mcov
+        $mcov,
       );
     }
 
@@ -210,11 +210,11 @@ final class DifferentialDiffTableOfContentsView extends AphrontView {
     $buttons = phutil_tag(
       'div',
       array(
-        'class' => 'differential-toc-buttons grouped'
+        'class' => 'differential-toc-buttons grouped',
       ),
       array(
         $editor_link,
-        $reveal_link
+        $reveal_link,
       ));
 
     $table = id(new AphrontTableView($rows));

src/applications/differential/view/DifferentialLocalCommitsView.php

@@ -144,7 +144,8 @@ final class DifferentialLocalCommitsView extends AphrontView {
       $link = phutil_tag(
         'a',
         array(
-          'href' => $commit_for_link->getURI()),
+          'href' => $commit_for_link->getURI(),
+        ),
         $commit_hash);
     } else {
       $link = $commit_hash;

src/applications/differential/view/DifferentialRevisionUpdateHistoryView.php

@@ -314,7 +314,7 @@ final class DifferentialRevisionUpdateHistoryView extends AphrontView {
       DifferentialLintStatus::LINT_FAIL => self::STAR_FAIL,
       DifferentialLintStatus::LINT_SKIP => self::STAR_SKIP,
       DifferentialLintStatus::LINT_AUTO_SKIP => self::STAR_SKIP,
-      DifferentialLintStatus::LINT_POSTPONED => self::STAR_SKIP
+      DifferentialLintStatus::LINT_POSTPONED => self::STAR_SKIP,
     );
 
     $star = idx($map, $diff->getLintStatus(), self::STAR_FAIL);

src/applications/diffusion/conduit/DiffusionDiffQueryConduitAPIMethod.php

@@ -81,7 +81,8 @@ final class DiffusionDiffQueryConduitAPIMethod
         if ($path->getTargetPath()) {
           $old = array(
             $path->getTargetPath(),
-            $path->getTargetCommitIdentifier());
+            $path->getTargetCommitIdentifier(),
+          );
         } else {
           $old = array($path->getPath(), $path->getCommitIdentifier() - 1);
         }
@@ -99,7 +100,8 @@ final class DiffusionDiffQueryConduitAPIMethod
       case DifferentialChangeType::TYPE_COPY_HERE:
         $old = array(
           $path->getTargetPath(),
-          $path->getTargetCommitIdentifier());
+          $path->getTargetCommitIdentifier(),
+        );
         $new = array($path->getPath(), $path->getCommitIdentifier());
         $old_name = $path->getTargetPath();
         $new_name = $path->getPath();
@@ -107,7 +109,8 @@ final class DiffusionDiffQueryConduitAPIMethod
       case DifferentialChangeType::TYPE_MOVE_AWAY:
         $old = array(
           $path->getPath(),
-          $path->getCommitIdentifier() - 1);
+          $path->getCommitIdentifier() - 1,
+        );
         $old_name = $path->getPath();
         $new_name = null;
         $new = null;

src/applications/diffusion/conduit/DiffusionExistsQueryConduitAPIMethod.php

@@ -17,7 +17,7 @@ final class DiffusionExistsQueryConduitAPIMethod
 
   protected function defineCustomParamTypes() {
     return array(
-      'commit' => 'required string'
+      'commit' => 'required string',
     );
   }
 

src/applications/diffusion/conduit/DiffusionGetRecentCommitsByPathConduitAPIMethod.php

@@ -54,7 +54,8 @@ final class DiffusionGetRecentCommitsByPathConduitAPIMethod
         'offset' => 0,
         'limit' => $limit,
         'needDirectChanges' => true,
-        'needChildChanges' => true));
+        'needChildChanges' => true,
+      ));
     $history = DiffusionPathChange::newFromConduit(
       $history_result['pathChanges']);
 

src/applications/diffusion/conduit/DiffusionQueryCommitsConduitAPIMethod.php

@@ -119,7 +119,8 @@ final class DiffusionQueryCommitsConduitAPIMethod
         foreach ($lowlevel_commitref->getHashes() as $hash) {
           $dict['hashes'][] = array(
             'type' => $hash->getHashType(),
-            'value' => $hash->getHashValue());
+            'value' => $hash->getHashValue(),
+          );
         }
       }
 

src/applications/diffusion/conduit/DiffusionQueryConduitAPIMethod.php

@@ -42,7 +42,8 @@ abstract class DiffusionQueryConduitAPIMethod
         'ERR-UNKNOWN-VCS-TYPE' =>
           pht('Unknown repository VCS type.'),
         'ERR-UNSUPPORTED-VCS' =>
-          pht('VCS is not supported for this method.'));
+          pht('VCS is not supported for this method.'),
+      );
   }
 
   /**

src/applications/diffusion/conduit/DiffusionRefsQueryConduitAPIMethod.php

@@ -49,7 +49,8 @@ final class DiffusionRefsQueryConduitAPIMethod
           array(
             'action'  => 'browse',
             'branch'  => $ref,
-          )));
+          )),
+      );
     }
 
     return $ref_links;

src/applications/diffusion/conduit/DiffusionSearchQueryConduitAPIMethod.php

@@ -27,7 +27,8 @@ final class DiffusionSearchQueryConduitAPIMethod
 
   protected function defineCustomErrorTypes() {
     return array(
-      'ERR-GREP-COMMAND' => 'Grep command failed.');
+      'ERR-GREP-COMMAND' => 'Grep command failed.',
+    );
   }
 
   protected function getResult(ConduitAPIRequest $request) {

src/applications/diffusion/controller/DiffusionBranchTableController.php

@@ -22,7 +22,7 @@ final class DiffusionBranchTableController extends DiffusionController {
       'diffusion.branchquery',
       array(
         'offset' => $pager->getOffset(),
-        'limit' => $pager->getPageSize() + 1
+        'limit' => $pager->getPageSize() + 1,
       ));
     $branches = $pager->sliceResults($branches);
 

src/applications/diffusion/controller/DiffusionBrowseFileController.php

@@ -1016,7 +1016,8 @@ final class DiffusionBrowseFileController extends DiffusionBrowseController {
       array(
         'commit' => $drequest->getCommit(),
         'path' => $drequest->getPath(),
-        'againstCommit' => $target_commit));
+        'againstCommit' => $target_commit,
+      ));
     $old_line = 0;
     $new_line = 0;
 

src/applications/diffusion/controller/DiffusionChangeController.php

@@ -43,7 +43,7 @@ final class DiffusionChangeController extends DiffusionController {
     $changeset_view->setVisibleChangesets($changesets);
     $changeset_view->setRenderingReferences(
       array(
-        0 => $drequest->generateURI(array('action' => 'rendering-ref'))
+        0 => $drequest->generateURI(array('action' => 'rendering-ref')),
       ));
 
     $raw_params = array(

src/applications/diffusion/controller/DiffusionCommitController.php

@@ -796,7 +796,7 @@ final class DiffusionCommitController extends DiffusionController {
       'aphront-panel-preview aphront-panel-flush',
       array(
         phutil_tag('div', array('id' => 'audit-preview'), $loading),
-        phutil_tag('div', array('id' => 'inline-comment-preview'))
+        phutil_tag('div', array('id' => 'inline-comment-preview')),
       ));
 
     // TODO: This is pretty awkward, unify the CSS between Diffusion and
@@ -911,7 +911,8 @@ final class DiffusionCommitController extends DiffusionController {
         'diffusion.mergedcommitsquery',
         array(
           'commit' => $drequest->getCommit(),
-          'limit' => $limit + 1));
+          'limit' => $limit + 1,
+        ));
     } catch (ConduitException $ex) {
       if ($ex->getMessage() != 'ERR-UNSUPPORTED-VCS') {
         throw $ex;
@@ -1026,7 +1027,8 @@ final class DiffusionCommitController extends DiffusionController {
       'diffusion.rawdiffquery',
       array(
         'commit' => $drequest->getCommit(),
-        'path' => $drequest->getPath()));
+        'path' => $drequest->getPath(),
+      ));
 
     $file = PhabricatorFile::buildFromFileDataOrHash(
       $raw_diff,

src/applications/diffusion/controller/DiffusionCommitTagsController.php

@@ -22,7 +22,8 @@ final class DiffusionCommitTagsController extends DiffusionController {
           'diffusion.tagsquery',
           array(
             'commit' => $request->getCommit(),
-            'limit' => $tag_limit + 1)));
+            'limit' => $tag_limit + 1,
+          )));
     } catch (ConduitException $ex) {
       if ($ex->getMessage() != 'ERR-UNSUPPORTED-VCS') {
         throw $ex;

src/applications/diffusion/controller/DiffusionController.php

@@ -184,7 +184,8 @@ abstract class DiffusionController extends PhabricatorController {
     $divider = phutil_tag(
       'span',
       array(
-        'class' => 'phui-header-divider'),
+        'class' => 'phui-header-divider',
+      ),
       '/');
 
     $links = array();

src/applications/diffusion/controller/DiffusionDiffController.php

@@ -50,7 +50,8 @@ final class DiffusionDiffController extends DiffusionController {
       'diffusion.diffquery',
       array(
         'commit' => $drequest->getCommit(),
-        'path' => $drequest->getPath()));
+        'path' => $drequest->getPath(),
+      ));
     $drequest->updateSymbolicCommit($data['effectiveCommit']);
     $raw_changes = ArcanistDiffChange::newFromConduit($data['changes']);
     $diff = DifferentialDiff::newFromRawChanges($raw_changes);
@@ -66,7 +67,8 @@ final class DiffusionDiffController extends DiffusionController {
     $parser->setChangeset($changeset);
     $parser->setRenderingReference($drequest->generateURI(
       array(
-        'action' => 'rendering-ref')));
+        'action' => 'rendering-ref',
+      )));
 
     $parser->setCharacterEncoding($request->getStr('encoding'));
     $parser->setHighlightAs($request->getStr('highlight'));

src/applications/diffusion/controller/DiffusionHistoryController.php

@@ -19,7 +19,8 @@ final class DiffusionHistoryController extends DiffusionController {
       'commit' => $drequest->getCommit(),
       'path' => $drequest->getPath(),
       'offset' => $offset,
-      'limit' => $page_size + 1);
+      'limit' => $page_size + 1,
+    );
 
     if (!$request->getBool('copies')) {
       $params['needDirectChanges'] = true;

src/applications/diffusion/controller/DiffusionLastModifiedController.php

@@ -145,10 +145,12 @@ final class DiffusionLastModifiedController extends DiffusionController {
     if ($lint !== null) {
       $return['lint'] = phutil_tag(
         'a',
-        array('href' => $drequest->generateURI(array(
+        array(
-          'action' => 'lint',
+          'href' => $drequest->generateURI(array(
-          'lint' => null,
+            'action' => 'lint',
-        ))),
+            'lint' => null,
+          )),
+        ),
         number_format($lint));
     }
 

src/applications/diffusion/controller/DiffusionLintDetailsController.php

@@ -17,20 +17,24 @@ final class DiffusionLintDetailsController extends DiffusionController {
     foreach ($messages as $message) {
       $path = phutil_tag(
         'a',
-        array('href' => $drequest->generateURI(array(
+        array(
-          'action' => 'lint',
+          'href' => $drequest->generateURI(array(
-          'path' => $message['path'],
+            'action' => 'lint',
-        ))),
+            'path' => $message['path'],
+          )),
+        ),
         substr($message['path'], strlen($drequest->getPath()) + 1));
 
       $line = phutil_tag(
         'a',
-        array('href' => $drequest->generateURI(array(
+        array(
-          'action' => 'browse',
+          'href' => $drequest->generateURI(array(
-          'path' => $message['path'],
+            'action' => 'browse',
-          'line' => $message['line'],
+            'path' => $message['path'],
-          'commit' => $branch->getLintCommit(),
+            'line' => $message['line'],
-        ))),
+            'commit' => $branch->getLintCommit(),
+          )),
+        ),
         $message['line']);
 
       $author = $message['authorPHID'];
@@ -90,7 +94,8 @@ final class DiffusionLintDetailsController extends DiffusionController {
           array(
             pht('Lint'),
             $drequest->getRepository()->getCallsign(),
-      )));
+          ),
+      ));
   }
 
   private function loadLintMessages(

src/applications/diffusion/controller/DiffusionRepositoryController.php

@@ -96,7 +96,8 @@ final class DiffusionRepositoryController extends DiffusionController {
           'commit' => $drequest->getCommit(),
           'path' => $drequest->getPath(),
           'offset' => 0,
-          'limit' => 15));
+          'limit' => 15,
+        ));
       $history = DiffusionPathChange::newFromConduit(
         $history_results['pathChanges']);
 

src/applications/diffusion/controller/DiffusionRepositoryEditBasicController.php

@@ -144,7 +144,8 @@ final class DiffusionRepositoryEditBasicController
     return $this->buildApplicationPage(
       array(
         $crumbs,
-        $object_box),
+        $object_box,
+      ),
       array(
         'title' => $title,
       ));

src/applications/diffusion/controller/DiffusionRepositoryEditHostingController.php

@@ -186,7 +186,8 @@ final class DiffusionRepositoryEditHostingController
           '%s: This repository is hosted elsewhere, so Phabricator can not '.
           'perform writes. This mode will act like "Read Only" for '.
           'repositories hosted elsewhere.',
-          phutil_tag('strong', array(), 'WARNING')));
+          phutil_tag('strong', array(), 'WARNING')),
+      );
     }
 
     $ssh_control =

src/applications/diffusion/controller/DiffusionTagListController.php

@@ -19,7 +19,8 @@ final class DiffusionTagListController extends DiffusionController {
 
     $params = array(
       'limit' => $pager->getPageSize() + 1,
-      'offset' => $pager->getOffset());
+      'offset' => $pager->getOffset(),
+    );
 
     if ($drequest->getSymbolicCommit()) {
       $is_commit = true;

src/applications/diffusion/data/DiffusionBrowseResultSet.php

@@ -64,7 +64,8 @@ final class DiffusionBrowseResultSet {
       'isValidResults' => $this->isValidResults(),
       'reasonForEmptyResultSet' => $this->getReasonForEmptyResultSet(),
       'existedAtCommit' => $this->getExistedAtCommit(),
-      'deletedAtCommit' => $this->getDeletedAtCommit());
+      'deletedAtCommit' => $this->getDeletedAtCommit(),
+    );
   }
 
   public function getPathDicts() {

src/applications/diffusion/data/DiffusionFileContent.php

@@ -48,7 +48,7 @@ final class DiffusionFileContent {
       'corpus' => $this->getCorpus(),
       'blameDict' => $this->getBlameDict(),
       'revList' => $this->getRevList(),
-      'textList' => $this->getTextList()
+      'textList' => $this->getTextList(),
     );
   }
 

src/applications/diffusion/data/DiffusionPathChange.php

@@ -171,7 +171,8 @@ final class DiffusionPathChange {
       'changeType' => $this->getChangeType(),
       'targetPath' =>  $this->getTargetPath(),
       'targetCommitIdentifier' => $this->getTargetCommitIdentifier(),
-      'awayPaths' => $this->getAwayPaths());
+      'awayPaths' => $this->getAwayPaths(),
+    );
   }
 
   public static function newFromConduit(array $dicts) {

src/applications/diffusion/view/DiffusionBranchTableView.php

@@ -83,7 +83,7 @@ final class DiffusionBranchTableView extends DiffusionView {
               array(
                 'action' => 'history',
                 'branch' => $branch->getShortName(),
-              ))
+              )),
           ),
           pht('History')),
         phutil_tag(

src/applications/diffusion/view/DiffusionHistoryTableView.php

@@ -171,7 +171,8 @@ final class DiffusionHistoryTableView extends DiffusionView {
             'span',
             array(
               'sigil' => 'has-tooltip',
-              'meta' => array('tip' => $name)),
+              'meta' => array('tip' => $name),
+            ),
             $icon_view);
 
           Javelin::initBehavior('phabricator-tooltips');

src/applications/diviner/controller/DivinerAtomController.php

@@ -174,7 +174,8 @@ final class DivinerAtomController extends DivinerController {
                 $item = array(
                   $item,
                   " \xE2\x80\x94 ",
-                  $atom->getSummary());
+                  $atom->getSummary(),
+                );
               }
 
               $list_items[] = phutil_tag('li', array(), $item);
@@ -280,7 +281,8 @@ final class DivinerAtomController extends DivinerController {
           $items[] = array(
             $this->renderAtomTag($iface),
             "  \xE2\x97\x80  ",
-            $this->renderAtomTag($via));
+            $this->renderAtomTag($via),
+          );
         }
       }
 

src/applications/diviner/view/DivinerBookItemView.php

@@ -44,21 +44,21 @@ final class DivinerBookItemView extends AphrontTagView {
     $title = phutil_tag(
       'span',
         array(
-          'class' => 'diviner-book-item-title'
+          'class' => 'diviner-book-item-title',
         ),
       $this->title);
 
     $subtitle = phutil_tag(
       'span',
         array(
-          'class' => 'diviner-book-item-subtitle'
+          'class' => 'diviner-book-item-subtitle',
         ),
       $this->subtitle);
 
     $type = phutil_tag(
       'span',
         array(
-          'class' => 'diviner-book-item-type'
+          'class' => 'diviner-book-item-type',
         ),
       $this->type);
 

src/applications/diviner/view/DivinerParameterTableView.php

@@ -67,13 +67,14 @@ final class DivinerParameterTableView extends AphrontTagView {
     $table = phutil_tag(
       'table',
       array(
-        'class' => 'diviner-parameter-table-view'),
+        'class' => 'diviner-parameter-table-view',
+      ),
       $rows);
 
     $header = phutil_tag(
       'span',
       array(
-        'class' => 'diviner-table-header'
+        'class' => 'diviner-table-header',
       ),
       $this->header);
 

src/applications/diviner/view/DivinerReturnTableView.php

@@ -61,13 +61,14 @@ final class DivinerReturnTableView extends AphrontTagView {
     $table = phutil_tag(
       'table',
       array(
-        'class' => 'diviner-return-table-view'),
+        'class' => 'diviner-return-table-view',
+      ),
       $rows);
 
     $header = phutil_tag(
       'span',
       array(
-        'class' => 'diviner-table-header'
+        'class' => 'diviner-table-header',
       ),
       $this->header);
 

src/applications/doorkeeper/bridge/__tests__/DoorkeeperBridgeJIRATestCase.php

@@ -8,13 +8,13 @@ final class DoorkeeperBridgeJIRATestCase extends PhabricatorTestCase {
         // Installed at domain root.
         'http://jira.example.com/rest/api/2/issue/1',
         'TP-1',
-        'http://jira.example.com/browse/TP-1'
+        'http://jira.example.com/browse/TP-1',
       ),
       array(
         // Installed on path.
         'http://jira.example.com/jira/rest/api/2/issue/1',
         'TP-1',
-        'http://jira.example.com/jira/browse/TP-1'
+        'http://jira.example.com/jira/browse/TP-1',
       ),
       array(
         // A URI we don't understand.

src/applications/doorkeeper/option/PhabricatorAsanaConfigOptions.php

@@ -30,7 +30,7 @@ final class PhabricatorAsanaConfigOptions
             'object in Phabricator comes from. For example, you can add code '.
             'reviews in Asana to a "Differential" project.'.
             "\n\n".
-            'NOTE: This feature is new and experimental.'))
+            'NOTE: This feature is new and experimental.')),
     );
   }
 

src/applications/drydock/blueprint/DrydockPreallocatedHostBlueprintImplementation.php

@@ -108,14 +108,16 @@ final class DrydockPreallocatedHostBlueprintImplementation
             'host' => $resource->getAttribute('host'),
             'port' => $resource->getAttribute('port'),
             'credential' => $resource->getAttribute('credential'),
-            'platform' => $resource->getAttribute('platform')))
+            'platform' => $resource->getAttribute('platform'),
+          ))
           ->setWorkingDirectory($lease->getAttribute('path'));
       case 'filesystem':
         return id(new DrydockSFTPFilesystemInterface())
           ->setConfiguration(array(
             'host' => $resource->getAttribute('host'),
             'port' => $resource->getAttribute('port'),
-            'credential' => $resource->getAttribute('credential')));
+            'credential' => $resource->getAttribute('credential'),
+          ));
     }
 
     throw new Exception("No interface of type '{$type}'.");

src/applications/fact/management/PhabricatorFactManagementCursorsWorkflow.php

@@ -17,7 +17,7 @@ final class PhabricatorFactManagementCursorsWorkflow
             'param'   => 'cursor',
             'repeat'  => true,
             'help'    => 'Reset cursor __cursor__.',
-          )
+          ),
         ));
   }
 

src/applications/feed/conduit/FeedQueryConduitAPIMethod.php

@@ -128,7 +128,7 @@ final class FeedQueryConduitAPIMethod extends FeedConduitAPIMethod {
               'authorPHID' => $story_data->getAuthorPHID(),
               'chronologicalKey' => $story_data->getChronologicalKey(),
               'objectPHID' => $story->getPrimaryObjectPHID(),
-              'text' => $story->renderText()
+              'text' => $story->renderText(),
             );
           break;
           default:

src/applications/files/PhabricatorImageTransformer.php

@@ -215,7 +215,7 @@ final class PhabricatorImageTransformer {
       'dx' => $dx,
       'dy' => $dy,
       'sdx' => $sdx,
-      'sdy' => $sdy
+      'sdy' => $sdy,
     );
   }
 

src/applications/files/config/PhabricatorFilesConfigOptions.php

@@ -184,7 +184,7 @@ final class PhabricatorFilesConfigOptions
        ->setBoolOptions(
          array(
            pht('Enable'),
-           pht('Disable')
+           pht('Disable'),
          ))->setDescription(
              pht("This option will enable animated gif images".
                   "to be set as profile pictures. The 'convert' binary ".

src/applications/files/controller/PhabricatorFileInfoController.php

@@ -78,7 +78,7 @@ final class PhabricatorFileInfoController extends PhabricatorFileController {
       array(
         $crumbs,
         $object_box,
-        $timeline
+        $timeline,
       ),
       array(
         'title' => $file->getName(),
@@ -126,7 +126,8 @@ final class PhabricatorFileInfoController extends PhabricatorFileController {
 
     return array(
       $timeline,
-      $add_comment_form);
+      $add_comment_form,
+    );
   }
 
   private function buildActionView(PhabricatorFile $file) {

src/applications/flag/query/PhabricatorFlagSearchEngine.php

@@ -116,7 +116,8 @@ final class PhabricatorFlagSearchEngine
     // sort it alphabetically...
     asort($options);
     $default_option = array(
-      0 => pht('All Object Types'));
+      0 => pht('All Object Types'),
+    );
     // ...and stick the default option on front
     $options = array_merge($default_option, $options);
 

src/applications/harbormaster/controller/HarbormasterBuildViewController.php

@@ -299,7 +299,8 @@ final class HarbormasterBuildViewController
           'div',
           array(
             'style' => 'display: none',
-            'id' => $id),
+            'id' => $id,
+          ),
           $log_box);
       }
 
@@ -377,7 +378,8 @@ final class HarbormasterBuildViewController
         $link_100,
         ' - ',
         $link_0,
-        ' Lines'));
+        ' Lines',
+      ));
   }
 
   private function buildActionList(HarbormasterBuild $build) {
@@ -440,7 +442,8 @@ final class HarbormasterBuildViewController
       ->setViewer($viewer)
       ->withPHIDs(array(
         $build->getBuildablePHID(),
-        $build->getBuildPlanPHID()))
+        $build->getBuildPlanPHID(),
+      ))
       ->execute();
 
     $properties->addProperty(

src/applications/harbormaster/controller/HarbormasterPlanViewController.php

@@ -391,7 +391,8 @@ final class HarbormasterPlanViewController extends HarbormasterPlanController {
         $note = array(
           phutil_tag('strong', array(), pht('ERROR:')),
           ' ',
-          $error);
+          $error,
+        );
       } else {
         $note = $bound;
       }
@@ -457,7 +458,8 @@ final class HarbormasterPlanViewController extends HarbormasterPlanController {
         $note = array(
           phutil_tag('strong', array(), pht('ERROR:')),
           ' ',
-          $error);
+          $error,
+        );
       } else {
         $note = $bound;
       }

src/applications/harbormaster/editor/HarbormasterBuildTransactionEditor.php

@@ -94,7 +94,7 @@ final class HarbormasterBuildTransactionEditor
     PhabricatorWorker::scheduleTask(
       'HarbormasterBuildWorker',
       array(
-        'buildID' => $build->getID()
+        'buildID' => $build->getID(),
       ));
   }
 

src/applications/harbormaster/engine/HarbormasterBuildGraph.php

@@ -33,7 +33,8 @@ final class HarbormasterBuildGraph extends AbstractDirectedGraph {
       $results[] = array(
         'node' => $steps_by_phid[$node['node']],
         'depth' => $node['depth'],
-        'cycle' => $node['cycle']);
+        'cycle' => $node['cycle'],
+      );
     }
 
     return $results;

src/applications/harbormaster/step/HarbormasterLeaseHostBuildStepImplementation.php

@@ -37,7 +37,8 @@ final class HarbormasterLeaseHostBuildStepImplementation
       $settings['name'],
       HarbormasterBuildArtifact::TYPE_HOST);
     $artifact->setArtifactData(array(
-      'drydock-lease' => $lease->getID()));
+      'drydock-lease' => $lease->getID(),
+    ));
     $artifact->save();
   }