diff --git a/src/applications/notification/builder/PhabricatorNotificationBuilder.php b/src/applications/notification/builder/PhabricatorNotificationBuilder.php index c3fa3d5426..46c73003ea 100644 --- a/src/applications/notification/builder/PhabricatorNotificationBuilder.php +++ b/src/applications/notification/builder/PhabricatorNotificationBuilder.php @@ -129,7 +129,12 @@ final class PhabricatorNotificationBuilder { $null_view = new AphrontNullView(); foreach ($stories as $story) { - $view = $story->renderView(); + try { + $view = $story->renderView(); + } catch (Exception $ex) { + // TODO: Render a nice debuggable notice instead? + continue; + } $null_view->appendChild($view->renderNotification($this->user)); } diff --git a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php index fea78abb2a..dc43764c7d 100644 --- a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php +++ b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php @@ -2022,6 +2022,11 @@ abstract class PhabricatorApplicationTransactionEditor array $mailed_phids) { $xactions = mfilter($xactions, 'shouldHideForFeed', true); + + if (!$xactions) { + return; + } + $related_phids = $this->getFeedRelatedPHIDs($object, $xactions); $subscribed_phids = $this->getFeedNotifyPHIDs($object, $xactions);