revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-30 08:28:20 +01:00
Code Issues Releases Wiki Activity

Make "Tags" and "Branches" custom fields work properly in Diffusion

Browse source 
Summary: Ref T8295 (vaguely related). This old method has no callsites.

Test Plan: Generated mail, saw "Tags" and "Branches".

Reviewers: fabe, joshuaspence

Reviewed By: fabe, joshuaspence

Subscribers: epriestley

Maniphest Tasks: T8295

Differential Revision: https://secure.phabricator.com/D13000
This commit is contained in:
epriestley 2015-05-25 05:34:41 -07:00
parent 969a6a2b38
commit 3d2c6f1ed2
3 changed files with 10 additions and 24 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/applications/repository/customfield/PhabricatorCommitBranchesField.php
View file

@ -7,13 +7,14 @@ final class PhabricatorCommitBranchesField
return 'diffusion:branches'; return 'diffusion:branches';
} }
public function shouldAppearInApplicationTransactions() { public function shouldAppearInTransactionMail() {
return true; return true;
} }
public function buildApplicationTransactionMailBody( public function updateTransactionMailBody(
PhabricatorApplicationTransaction $xaction, PhabricatorMetaMTAMailBody $body,
PhabricatorMetaMTAMailBody $body) { PhabricatorApplicationTransactionEditor $editor,
array $xactions) {
$params = array( $params = array(
'contains' => $this->getObject()->getCommitIdentifier(), 'contains' => $this->getObject()->getCommitIdentifier(),

9
src/applications/repository/customfield/PhabricatorCommitTagsField.php
View file

@ -7,13 +7,14 @@ final class PhabricatorCommitTagsField
return 'diffusion:tags'; return 'diffusion:tags';
} }
public function shouldAppearInApplicationTransactions() { public function shouldAppearInTransactionMail() {
return true; return true;
} }
public function buildApplicationTransactionMailBody( public function updateTransactionMailBody(
PhabricatorApplicationTransaction $xaction, PhabricatorMetaMTAMailBody $body,
PhabricatorMetaMTAMailBody $body) { PhabricatorApplicationTransactionEditor $editor,
array $xactions) {
$params = array( $params = array(
'commit' => $this->getObject()->getCommitIdentifier(), 'commit' => $this->getObject()->getCommitIdentifier(),

16
src/infrastructure/customfield/field/PhabricatorCustomField.php
View file

@ -1055,22 +1055,6 @@ abstract class PhabricatorCustomField {
return false; return false;
} }
/**
* TODO: this is only used by Diffusion right now and everything is completely
* faked since Diffusion doesn't use ApplicationTransactions yet. This should
* get fleshed out as we have more use cases.
*
* @task appxaction
*/
public function buildApplicationTransactionMailBody(
PhabricatorApplicationTransaction $xaction,
PhabricatorMetaMTAMailBody $body) {
if ($this->proxy) {
return $this->proxy->buildApplicationTransactionMailBody($xaction, $body);
}
return;
}
/* -( Transaction Mail )--------------------------------------------------- */ /* -( Transaction Mail )--------------------------------------------------- */