revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-20 05:42:40 +01:00
Code Issues Releases Wiki Activity

Fix task + commit associating

Browse source 
Summary: we weren't actually removing any edges. now we do.

Test Plan: had a commit associated with task x; removed association. had a commit associated with task x; removed association while adding a different one.

Reviewers: floatinglomas, epriestley

Reviewed By: epriestley

CC: aran, Koolvin

Maniphest Tasks: T1256

Differential Revision: https://secure.phabricator.com/D2509
This commit is contained in:
Bob Trahan 2012-05-20 08:53:48 -07:00
parent de1973b516
commit 3d5d8d0f11
1 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/applications/search/controller/attach/PhabricatorSearchAttachController.php
View file

@ -68,10 +68,18 @@ final class PhabricatorSearchAttachController
case self::ACTION_EDGE: case self::ACTION_EDGE:
$edge_type = $this->getEdgeType($object_type, $attach_type); $edge_type = $this->getEdgeType($object_type, $attach_type);
$old_phids = PhabricatorEdgeQuery::loadDestinationPHIDs(
$this->phid,
$edge_type);
$add_phids = $phids;
$rem_phids = array_diff($old_phids, $add_phids);
$editor = id(new PhabricatorEdgeEditor()); $editor = id(new PhabricatorEdgeEditor());
foreach ($phids as $phid) { foreach ($add_phids as $phid) {
$editor->addEdge($this->phid, $edge_type, $phid); $editor->addEdge($this->phid, $edge_type, $phid);
} }
foreach ($rem_phids as $phid) {
$editor->removeEdge($this->phid, $edge_type, $phid);
}
$editor->save(); $editor->save();
return id(new AphrontReloadResponse())->setURI($handle->getURI()); return id(new AphrontReloadResponse())->setURI($handle->getURI());