From 3da020b4931c1ae6b5f4187ebea9c6fb43f9c639 Mon Sep 17 00:00:00 2001 From: Chad Little Date: Sat, 2 May 2015 09:02:02 -0700 Subject: [PATCH] Scope remarkup highlighting better Summary: These remarkup spans bleed into other areas, but afaik they only seem to be needed on the bright rule. Also normalized the height of the label, which changed when we changed button size. Test Plan: Review many diffs and inline comments. If this rule altered something else I can't find, let me know? Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12657 --- resources/celerity/map.php | 10 +++++----- .../application/differential/phui-inline-comment.css | 2 +- webroot/rsrc/css/core/syntax.css | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/resources/celerity/map.php b/resources/celerity/map.php index 158855937e..f5834ef223 100644 --- a/resources/celerity/map.php +++ b/resources/celerity/map.php @@ -7,7 +7,7 @@ */ return array( 'names' => array( - 'core.pkg.css' => '848ff3d3', + 'core.pkg.css' => '7a2366df', 'core.pkg.js' => '59d01bb7', 'darkconsole.pkg.js' => 'e7393ebb', 'differential.pkg.css' => '3500921f', @@ -58,7 +58,7 @@ return array( 'rsrc/css/application/differential/add-comment.css' => 'c47f8c40', 'rsrc/css/application/differential/changeset-view.css' => 'e19cfd6e', 'rsrc/css/application/differential/core.css' => '7ac3cabc', - 'rsrc/css/application/differential/phui-inline-comment.css' => 'ebe46529', + 'rsrc/css/application/differential/phui-inline-comment.css' => 'fc53e7c7', 'rsrc/css/application/differential/results-table.css' => '181aa9d9', 'rsrc/css/application/differential/revision-comment.css' => '024dda6b', 'rsrc/css/application/differential/revision-history.css' => '0e8eb855', @@ -109,7 +109,7 @@ return array( 'rsrc/css/application/uiexample/example.css' => '528b19de', 'rsrc/css/core/core.css' => '76e8ee93', 'rsrc/css/core/remarkup.css' => '0037bdbf', - 'rsrc/css/core/syntax.css' => '56c1ba38', + 'rsrc/css/core/syntax.css' => '6b7b24d9', 'rsrc/css/core/z-index.css' => '3b612549', 'rsrc/css/diviner/diviner-shared.css' => '38813222', 'rsrc/css/font/font-awesome.css' => 'e2e712fe', @@ -795,7 +795,7 @@ return array( 'phui-image-mask-css' => '5a8b09c8', 'phui-info-panel-css' => '27ea50a1', 'phui-info-view-css' => 'c6f0aef8', - 'phui-inline-comment-view-css' => 'ebe46529', + 'phui-inline-comment-view-css' => 'fc53e7c7', 'phui-list-view-css' => '2e25ebfb', 'phui-object-box-css' => '7d160002', 'phui-object-item-list-view-css' => '9db65899', @@ -834,7 +834,7 @@ return array( 'sprite-menu-css' => '9ef76324', 'sprite-projects-css' => 'b0d9e24f', 'sprite-tokens-css' => '1706b943', - 'syntax-highlighting-css' => '56c1ba38', + 'syntax-highlighting-css' => '6b7b24d9', 'tokens-css' => '3d0f239e', 'typeahead-browse-css' => 'd8581d2c', 'unhandled-exception-css' => '37d4f9a2', diff --git a/webroot/rsrc/css/application/differential/phui-inline-comment.css b/webroot/rsrc/css/application/differential/phui-inline-comment.css index d4f577c8b7..e923469803 100644 --- a/webroot/rsrc/css/application/differential/phui-inline-comment.css +++ b/webroot/rsrc/css/application/differential/phui-inline-comment.css @@ -278,7 +278,7 @@ border: 1px solid {$sh-yellowborder}; border-radius: 3px; display: inline-block; - padding: 3px 8px 4px; + padding: 4px 8px 5px; cursor: pointer; } diff --git a/webroot/rsrc/css/core/syntax.css b/webroot/rsrc/css/core/syntax.css index 4669c18647..28564ff154 100644 --- a/webroot/rsrc/css/core/syntax.css +++ b/webroot/rsrc/css/core/syntax.css @@ -15,7 +15,7 @@ padding: 1px 0 3px; } -.remarkup-code span { +.remarkup-code span.bright { border-bottom: 1px solid transparent; }