revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-23 14:00:56 +01:00
Code Issues Releases Wiki Activity

Fix a commit hook issue where pushing dangerous changes would fatal before hitting the dragon bureaucrats

Browse source 
Summary: See <https://discourse.phabricator-community.org/t/php-fatal-when-using-git-push-d/1317>. The behavioral changes for Herald on initial import from D19265 could leave `$all_updates` undefined if we throw early enough.

Test Plan: Pushed a dangerous change, saw dragon bureaucrats again.

Differential Revision: https://secure.phabricator.com/D19297
This commit is contained in:
epriestley 2018-04-05 05:26:23 -07:00
parent e70c9f72a4
commit 3de002c841
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/applications/diffusion/engine/DiffusionCommitHookEngine.php
View file

@ -126,6 +126,7 @@ final class DiffusionCommitHookEngine extends Phobject {
public function execute() {
$ref_updates = $this->findRefUpdates();
$all_updates = $ref_updates;
$caught = null;
try {