mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-23 05:50:55 +01:00
Add a <reviewer, revision> key to the reviewers table
Summary: Ref T10967. I'm not 100% sure we need this, but the old edge table had it and I recall an issue long ago where not having this key left us with a bad query plan. Our data doesn't really provide a way to test this key (we have many revisions and few reviewers, so the query planner always uses revision keys), and building a convincing test case would take a while (lipsum needs some improvements to add reviewers). But in the worst case this key is mostly useless and wastes a few MB of disk space, which isn't a big deal. So I can't conclusively prove that this key does anything to the dashboard query, but the migration removed it and I'm more comfortable keeping it so I'm not worried about breaking stuff. At the very least, MySQL does select this key in the query plan when I do a "Reviewers:" query explicitly so it isn't //useless//. Test Plan: Ran `bin/storage upgrade`, ran dashboard query, the query plan didn't get any worse. Reviewers: chad Reviewed By: chad Maniphest Tasks: T10967 Differential Revision: https://secure.phabricator.com/D17532
This commit is contained in:
parent
8913552970
commit
3e7b63aa73
1 changed files with 3 additions and 0 deletions
|
@ -23,6 +23,9 @@ final class DifferentialReviewer
|
|||
'columns' => array('revisionPHID', 'reviewerPHID'),
|
||||
'unique' => true,
|
||||
),
|
||||
'key_reviewer' => array(
|
||||
'columns' => array('reviewerPHID', 'revisionPHID'),
|
||||
),
|
||||
),
|
||||
) + parent::getConfiguration();
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue