From 3e983b583dc0b5c46aa0702b346fbd552766a318 Mon Sep 17 00:00:00 2001 From: epriestley Date: Tue, 16 Jan 2018 11:01:29 -0800 Subject: [PATCH] Fix a transposed feed story in Badges Summary: See . These are swapped. Test Plan: Changed a badge quality, viewed feed story, saw it position the strings correctly. Reviewers: amckinley Reviewed By: amckinley Differential Revision: https://secure.phabricator.com/D18870 --- .../xaction/PhabricatorBadgesBadgeQualityTransaction.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/applications/badges/xaction/PhabricatorBadgesBadgeQualityTransaction.php b/src/applications/badges/xaction/PhabricatorBadgesBadgeQualityTransaction.php index de060c17e7..fc1bf014c0 100644 --- a/src/applications/badges/xaction/PhabricatorBadgesBadgeQualityTransaction.php +++ b/src/applications/badges/xaction/PhabricatorBadgesBadgeQualityTransaction.php @@ -37,11 +37,11 @@ final class PhabricatorBadgesBadgeQualityTransaction $new = $this->getQualityLabel($this->getNewValue()); return pht( - '%s updated %s quality from %s to %s.', + '%s updated the quality of %s from %s to %s.', $this->renderAuthor(), $this->renderObject(), - $new, - $old); + $old, + $new); } public function validateTransactions($object, array $xactions) {