mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-10 00:42:41 +01:00
Add audit, review, and dominion information to "owners.search" API method
Summary: See PHI439. This fills in additional information about Owners packages. Also removes dead `primaryOwnerPHID`. Test Plan: Called `owners.search` and reviewed the results. Grepped for `primaryOwnerPHID`. Differential Revision: https://secure.phabricator.com/D19207
This commit is contained in:
parent
1763b516b1
commit
3e992c6713
2 changed files with 43 additions and 2 deletions
|
@ -0,0 +1,2 @@
|
||||||
|
ALTER TABLE {$NAMESPACE}_owners.owners_package
|
||||||
|
DROP primaryOwnerPHID;
|
|
@ -16,7 +16,6 @@ final class PhabricatorOwnersPackage
|
||||||
protected $auditingEnabled;
|
protected $auditingEnabled;
|
||||||
protected $autoReview;
|
protected $autoReview;
|
||||||
protected $description;
|
protected $description;
|
||||||
protected $primaryOwnerPHID;
|
|
||||||
protected $mailKey;
|
protected $mailKey;
|
||||||
protected $status;
|
protected $status;
|
||||||
protected $viewPolicy;
|
protected $viewPolicy;
|
||||||
|
@ -122,7 +121,6 @@ final class PhabricatorOwnersPackage
|
||||||
self::CONFIG_COLUMN_SCHEMA => array(
|
self::CONFIG_COLUMN_SCHEMA => array(
|
||||||
'name' => 'sort',
|
'name' => 'sort',
|
||||||
'description' => 'text',
|
'description' => 'text',
|
||||||
'primaryOwnerPHID' => 'phid?',
|
|
||||||
'auditingEnabled' => 'bool',
|
'auditingEnabled' => 'bool',
|
||||||
'mailKey' => 'bytes20',
|
'mailKey' => 'bytes20',
|
||||||
'status' => 'text32',
|
'status' => 'text32',
|
||||||
|
@ -601,6 +599,18 @@ final class PhabricatorOwnersPackage
|
||||||
->setKey('owners')
|
->setKey('owners')
|
||||||
->setType('list<map<string, wild>>')
|
->setType('list<map<string, wild>>')
|
||||||
->setDescription(pht('List of package owners.')),
|
->setDescription(pht('List of package owners.')),
|
||||||
|
id(new PhabricatorConduitSearchFieldSpecification())
|
||||||
|
->setKey('review')
|
||||||
|
->setType('map<string, wild>')
|
||||||
|
->setDescription(pht('Auto review information.')),
|
||||||
|
id(new PhabricatorConduitSearchFieldSpecification())
|
||||||
|
->setKey('audit')
|
||||||
|
->setType('map<string, wild>')
|
||||||
|
->setDescription(pht('Auto audit information.')),
|
||||||
|
id(new PhabricatorConduitSearchFieldSpecification())
|
||||||
|
->setKey('dominion')
|
||||||
|
->setType('string')
|
||||||
|
->setDescription(pht('Dominion setting.')),
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -612,11 +622,40 @@ final class PhabricatorOwnersPackage
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
$review_map = self::getAutoreviewOptionsMap();
|
||||||
|
$review_value = $this->getAutoReview();
|
||||||
|
if (isset($review_map[$review_value])) {
|
||||||
|
$review_label = $review_map[$review_value]['name'];
|
||||||
|
} else {
|
||||||
|
$review_label = pht('Unknown ("%s")', $review_value);
|
||||||
|
}
|
||||||
|
|
||||||
|
$review = array(
|
||||||
|
'value' => $review_value,
|
||||||
|
'label' => $review_label,
|
||||||
|
);
|
||||||
|
|
||||||
|
if ($this->getAuditingEnabled()) {
|
||||||
|
$audit_value = 'audit';
|
||||||
|
$audit_label = pht('Auditing Enabled');
|
||||||
|
} else {
|
||||||
|
$audit_value = 'none';
|
||||||
|
$audit_label = pht('No Auditing');
|
||||||
|
}
|
||||||
|
|
||||||
|
$audit = array(
|
||||||
|
'value' => $audit_value,
|
||||||
|
'label' => $audit_label,
|
||||||
|
);
|
||||||
|
|
||||||
return array(
|
return array(
|
||||||
'name' => $this->getName(),
|
'name' => $this->getName(),
|
||||||
'description' => $this->getDescription(),
|
'description' => $this->getDescription(),
|
||||||
'status' => $this->getStatus(),
|
'status' => $this->getStatus(),
|
||||||
'owners' => $owner_list,
|
'owners' => $owner_list,
|
||||||
|
'review' => $review,
|
||||||
|
'audit' => $audit,
|
||||||
|
'dominion' => $this->getDominion(),
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue