From 3ec80a36dbeea5631c84fb1054b7d438f16df71f Mon Sep 17 00:00:00 2001 From: epriestley Date: Tue, 13 Feb 2018 03:34:51 -0800 Subject: [PATCH] In Drydock log views, respect newlines Summary: Depends on D19070. Ref T13073. Some messages contain an interesting story or a clever anecdote. Respect newlines during rendering to preserve authorial intent. Test Plan: Viewed a message with linebreaks and could still read it. {F5427754} Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam Maniphest Tasks: T13073 Differential Revision: https://secure.phabricator.com/D19071 --- src/applications/drydock/view/DrydockLogListView.php | 1 + 1 file changed, 1 insertion(+) diff --git a/src/applications/drydock/view/DrydockLogListView.php b/src/applications/drydock/view/DrydockLogListView.php index 845457f9bc..cb66813507 100644 --- a/src/applications/drydock/view/DrydockLogListView.php +++ b/src/applications/drydock/view/DrydockLogListView.php @@ -53,6 +53,7 @@ final class DrydockLogListView extends AphrontView { $type = $type_object->getLogTypeName(); $icon = $type_object->getLogTypeIcon($log_data); $data = $type_object->renderLog($log_data); + $data = phutil_escape_html_newlines($data); } else { $type = pht('', $type_key); $data = null;