1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-20 13:52:40 +01:00

Simplify handle rendering in search view

Summary:
Commits don't need special treatment since we have commit summaries. They're cool.

Also, this saves us some queries (I think, not sure).

Test Plan: Searched before and after this patch. Results look cool (the same).

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D5546
This commit is contained in:
epriestley 2013-04-02 16:48:50 -07:00
parent 42b47fd23c
commit 3ed75109e6
2 changed files with 42 additions and 57 deletions

View file

@ -527,8 +527,8 @@ celerity_register_resource_map(array(
),
'/rsrc/image/sprite-apps-large.png' =>
array(
'hash' => '2fa8b3624f11ae21ff15d9963a9133cd',
'uri' => '/res/2fa8b362/rsrc/image/sprite-apps-large.png',
'hash' => '1a3450de33a14b766cfffacc6d82b118',
'uri' => '/res/1a3450de/rsrc/image/sprite-apps-large.png',
'disk' => '/rsrc/image/sprite-apps-large.png',
'type' => 'png',
),
@ -3699,7 +3699,7 @@ celerity_register_resource_map(array(
),
'sprite-apps-large-css' =>
array(
'uri' => '/res/ad4d807a/rsrc/css/sprite-apps-large.css',
'uri' => '/res/2a3d0d2e/rsrc/css/sprite-apps-large.css',
'type' => 'css',
'requires' =>
array(
@ -3808,7 +3808,7 @@ celerity_register_resource_map(array(
), array(
'packages' =>
array(
'b7a4c0e3' =>
'0fb11fe9' =>
array(
'name' => 'core.pkg.css',
'symbols' =>
@ -3850,7 +3850,7 @@ celerity_register_resource_map(array(
34 => 'phabricator-object-item-list-view-css',
35 => 'global-drag-and-drop-css',
),
'uri' => '/res/pkg/b7a4c0e3/core.pkg.css',
'uri' => '/res/pkg/0fb11fe9/core.pkg.css',
'type' => 'css',
),
'd95b69e5' =>
@ -4040,16 +4040,16 @@ celerity_register_resource_map(array(
'reverse' =>
array(
'aphront-attached-file-view-css' => '6b1fccc6',
'aphront-dialog-view-css' => 'b7a4c0e3',
'aphront-error-view-css' => 'b7a4c0e3',
'aphront-form-view-css' => 'b7a4c0e3',
'aphront-list-filter-view-css' => 'b7a4c0e3',
'aphront-pager-view-css' => 'b7a4c0e3',
'aphront-panel-view-css' => 'b7a4c0e3',
'aphront-table-view-css' => 'b7a4c0e3',
'aphront-tokenizer-control-css' => 'b7a4c0e3',
'aphront-tooltip-css' => 'b7a4c0e3',
'aphront-typeahead-control-css' => 'b7a4c0e3',
'aphront-dialog-view-css' => '0fb11fe9',
'aphront-error-view-css' => '0fb11fe9',
'aphront-form-view-css' => '0fb11fe9',
'aphront-list-filter-view-css' => '0fb11fe9',
'aphront-pager-view-css' => '0fb11fe9',
'aphront-panel-view-css' => '0fb11fe9',
'aphront-table-view-css' => '0fb11fe9',
'aphront-tokenizer-control-css' => '0fb11fe9',
'aphront-tooltip-css' => '0fb11fe9',
'aphront-typeahead-control-css' => '0fb11fe9',
'differential-changeset-view-css' => '8aaacd1b',
'differential-core-view-css' => '8aaacd1b',
'differential-inline-comment-editor' => 'e96b08f8',
@ -4063,7 +4063,7 @@ celerity_register_resource_map(array(
'differential-table-of-contents-css' => '8aaacd1b',
'diffusion-commit-view-css' => 'c8ce2d88',
'diffusion-icons-css' => 'c8ce2d88',
'global-drag-and-drop-css' => 'b7a4c0e3',
'global-drag-and-drop-css' => '0fb11fe9',
'inline-comment-summary-css' => '8aaacd1b',
'javelin-aphlict' => 'd95b69e5',
'javelin-behavior' => 'fe22443b',
@ -4135,47 +4135,47 @@ celerity_register_resource_map(array(
'javelin-util' => 'fe22443b',
'javelin-vector' => 'fe22443b',
'javelin-workflow' => 'fe22443b',
'lightbox-attachment-css' => 'b7a4c0e3',
'lightbox-attachment-css' => '0fb11fe9',
'maniphest-task-summary-css' => '6b1fccc6',
'maniphest-transaction-detail-css' => '6b1fccc6',
'phabricator-busy' => 'd95b69e5',
'phabricator-content-source-view-css' => '8aaacd1b',
'phabricator-core-buttons-css' => 'b7a4c0e3',
'phabricator-core-css' => 'b7a4c0e3',
'phabricator-crumbs-view-css' => 'b7a4c0e3',
'phabricator-directory-css' => 'b7a4c0e3',
'phabricator-core-buttons-css' => '0fb11fe9',
'phabricator-core-css' => '0fb11fe9',
'phabricator-crumbs-view-css' => '0fb11fe9',
'phabricator-directory-css' => '0fb11fe9',
'phabricator-drag-and-drop-file-upload' => 'e96b08f8',
'phabricator-dropdown-menu' => 'd95b69e5',
'phabricator-file-upload' => 'd95b69e5',
'phabricator-filetree-view-css' => 'b7a4c0e3',
'phabricator-flag-css' => 'b7a4c0e3',
'phabricator-form-view-css' => 'b7a4c0e3',
'phabricator-header-view-css' => 'b7a4c0e3',
'phabricator-jump-nav' => 'b7a4c0e3',
'phabricator-filetree-view-css' => '0fb11fe9',
'phabricator-flag-css' => '0fb11fe9',
'phabricator-form-view-css' => '0fb11fe9',
'phabricator-header-view-css' => '0fb11fe9',
'phabricator-jump-nav' => '0fb11fe9',
'phabricator-keyboard-shortcut' => 'd95b69e5',
'phabricator-keyboard-shortcut-manager' => 'd95b69e5',
'phabricator-main-menu-view' => 'b7a4c0e3',
'phabricator-main-menu-view' => '0fb11fe9',
'phabricator-menu-item' => 'd95b69e5',
'phabricator-nav-view-css' => 'b7a4c0e3',
'phabricator-nav-view-css' => '0fb11fe9',
'phabricator-notification' => 'd95b69e5',
'phabricator-notification-css' => 'b7a4c0e3',
'phabricator-notification-menu-css' => 'b7a4c0e3',
'phabricator-object-item-list-view-css' => 'b7a4c0e3',
'phabricator-notification-css' => '0fb11fe9',
'phabricator-notification-menu-css' => '0fb11fe9',
'phabricator-object-item-list-view-css' => '0fb11fe9',
'phabricator-object-selector-css' => '8aaacd1b',
'phabricator-prefab' => 'd95b69e5',
'phabricator-project-tag-css' => '6b1fccc6',
'phabricator-remarkup-css' => 'b7a4c0e3',
'phabricator-remarkup-css' => '0fb11fe9',
'phabricator-shaped-request' => 'e96b08f8',
'phabricator-side-menu-view-css' => 'b7a4c0e3',
'phabricator-standard-page-view' => 'b7a4c0e3',
'phabricator-side-menu-view-css' => '0fb11fe9',
'phabricator-standard-page-view' => '0fb11fe9',
'phabricator-textareautils' => 'd95b69e5',
'phabricator-tooltip' => 'd95b69e5',
'phabricator-transaction-view-css' => 'b7a4c0e3',
'phabricator-zindex-css' => 'b7a4c0e3',
'sprite-apps-large-css' => 'b7a4c0e3',
'sprite-gradient-css' => 'b7a4c0e3',
'sprite-icon-css' => 'b7a4c0e3',
'sprite-menu-css' => 'b7a4c0e3',
'syntax-highlighting-css' => 'b7a4c0e3',
'phabricator-transaction-view-css' => '0fb11fe9',
'phabricator-zindex-css' => '0fb11fe9',
'sprite-apps-large-css' => '0fb11fe9',
'sprite-gradient-css' => '0fb11fe9',
'sprite-icon-css' => '0fb11fe9',
'sprite-menu-css' => '0fb11fe9',
'syntax-highlighting-css' => '0fb11fe9',
),
));

View file

@ -53,22 +53,7 @@ final class PhabricatorSearchResultView extends AphrontView {
'');
}
switch ($handle->getType()) {
case PhabricatorPHIDConstants::PHID_TYPE_CMIT:
$object_name = $handle->getName();
if ($this->object) {
$data = $this->object->loadOneRelative(
new PhabricatorRepositoryCommitData(),
'commitID');
if ($data && strlen($data->getSummary())) {
$object_name = $handle->getName().': '.$data->getSummary();
}
}
break;
default:
$object_name = $handle->getFullName();
break;
}
$object_name = $handle->getFullName();
return hsprintf(
'<div class="phabricator-search-result">'.