From 3edd01bc0fa289ba2800f2abd45d412690d3e220 Mon Sep 17 00:00:00 2001
From: Chad Little <chad@phacility.com>
Date: Sun, 27 Nov 2016 17:58:53 -0800
Subject: [PATCH] Remove english from lightbox javascript

Summary: Reduces to x / y for lightbox. Adds spacing. Ref T3612

Test Plan: Review spacing in sandbox.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Maniphest Tasks: T3612

Differential Revision: https://secure.phabricator.com/D16951
---
 resources/celerity/map.php                    | 30 +++++++++----------
 webroot/rsrc/css/phui/phui-lightbox.css       |  2 +-
 .../js/core/behavior-lightbox-attachments.js  |  2 +-
 3 files changed, 17 insertions(+), 17 deletions(-)

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
index 60673078c8..c59814fc7b 100644
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -9,8 +9,8 @@ return array(
   'names' => array(
     'conpherence.pkg.css' => '0b64e988',
     'conpherence.pkg.js' => '6249a1cf',
-    'core.pkg.css' => 'adfb9c57',
-    'core.pkg.js' => '519f84e8',
+    'core.pkg.css' => '4107e0f7',
+    'core.pkg.js' => '11c6a1ec',
     'darkconsole.pkg.js' => 'e7393ebb',
     'differential.pkg.css' => 'a4ba74b5',
     'differential.pkg.js' => '634399e9',
@@ -151,7 +151,7 @@ return array(
     'rsrc/css/phui/phui-info-panel.css' => '27ea50a1',
     'rsrc/css/phui/phui-info-view.css' => 'ec92802a',
     'rsrc/css/phui/phui-invisible-character-view.css' => '6993d9f0',
-    'rsrc/css/phui/phui-lightbox.css' => '04367b4f',
+    'rsrc/css/phui/phui-lightbox.css' => 'cbc9b891',
     'rsrc/css/phui/phui-list.css' => '9da2aa00',
     'rsrc/css/phui/phui-object-box.css' => '6b487c57',
     'rsrc/css/phui/phui-object-item-list-view.css' => '87278fa0',
@@ -505,7 +505,7 @@ return array(
     'rsrc/js/core/behavior-hovercard.js' => 'bcaccd64',
     'rsrc/js/core/behavior-keyboard-pager.js' => 'a8da01f0',
     'rsrc/js/core/behavior-keyboard-shortcuts.js' => '01fca1f0',
-    'rsrc/js/core/behavior-lightbox-attachments.js' => '2674e4fa',
+    'rsrc/js/core/behavior-lightbox-attachments.js' => '0b4ac79f',
     'rsrc/js/core/behavior-line-linker.js' => '1499a8cb',
     'rsrc/js/core/behavior-more.js' => 'a80d0378',
     'rsrc/js/core/behavior-object-selector.js' => 'e0ec7f2f',
@@ -651,7 +651,7 @@ return array(
     'javelin-behavior-history-install' => '7ee2b591',
     'javelin-behavior-icon-composer' => '8499b6ab',
     'javelin-behavior-launch-icon-composer' => '48086888',
-    'javelin-behavior-lightbox-attachments' => '2674e4fa',
+    'javelin-behavior-lightbox-attachments' => '0b4ac79f',
     'javelin-behavior-line-chart' => 'e4232876',
     'javelin-behavior-load-blame' => '42126667',
     'javelin-behavior-maniphest-batch-editor' => '782ab6e7',
@@ -869,7 +869,7 @@ return array(
     'phui-info-view-css' => 'ec92802a',
     'phui-inline-comment-view-css' => '5953c28e',
     'phui-invisible-character-view-css' => '6993d9f0',
-    'phui-lightbox-css' => '04367b4f',
+    'phui-lightbox-css' => 'cbc9b891',
     'phui-list-view-css' => '9da2aa00',
     'phui-object-box-css' => '6b487c57',
     'phui-object-item-list-view-css' => '87278fa0',
@@ -991,6 +991,15 @@ return array(
       'javelin-dom',
       'javelin-router',
     ),
+    '0b4ac79f' => array(
+      'javelin-behavior',
+      'javelin-stratcom',
+      'javelin-dom',
+      'javelin-mask',
+      'javelin-util',
+      'phuix-icon-view',
+      'phabricator-busy',
+    ),
     '0f764c35' => array(
       'javelin-install',
       'javelin-util',
@@ -1106,15 +1115,6 @@ return array(
       'javelin-workflow',
       'javelin-util',
     ),
-    '2674e4fa' => array(
-      'javelin-behavior',
-      'javelin-stratcom',
-      'javelin-dom',
-      'javelin-mask',
-      'javelin-util',
-      'phuix-icon-view',
-      'phabricator-busy',
-    ),
     '2926fff2' => array(
       'javelin-behavior',
       'javelin-dom',
diff --git a/webroot/rsrc/css/phui/phui-lightbox.css b/webroot/rsrc/css/phui/phui-lightbox.css
index e4122c6977..122802ab25 100644
--- a/webroot/rsrc/css/phui/phui-lightbox.css
+++ b/webroot/rsrc/css/phui/phui-lightbox.css
@@ -107,7 +107,7 @@
 
 .lightbox-attachment .lightbox-status a {
   color: #000;
-  margin-right: 4px;
+  margin-right: 12px;
   font-size: {$biggerfontsize};
 }
 
diff --git a/webroot/rsrc/js/core/behavior-lightbox-attachments.js b/webroot/rsrc/js/core/behavior-lightbox-attachments.js
index 95b3edacb3..5ee6173859 100644
--- a/webroot/rsrc/js/core/behavior-lightbox-attachments.js
+++ b/webroot/rsrc/js/core/behavior-lightbox-attachments.js
@@ -153,7 +153,7 @@ JX.behavior('lightbox-attachments', function (config) {
         },
         [
           m_url,
-          ' Image ' + current + ' of ' + total + '.'
+          current + ' / ' + total
         ]
       );