Reduce PhabricatorUser::getOmnipotentUser calls by adding a getViewer method to PhbaricatorDestructionEngine

Summary:
Fixes T6956. Before this change, we called PhabricatorUser::getOmnipotentUser in the various delete methods to query the data. Now, we use $engine->getViewer(), since its always a good thing to have less calls to PhabricatorUser::getOmnipotentUser thrown around the codebase.

I used the "codemod" tool to audit the existing calls to PhabricatorDestructorEngine (all of them) so ostensibly this gets all the spots. If I missed something though, its still going to work, so this change is very low risk.

Test Plan: ./bin/remove destroy P1; visit P1 and get a 404

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T6956

Differential Revision: https://secure.phabricator.com/D12866

src/applications/almanac/storage/AlmanacDevice.php

@@ -240,7 +240,7 @@ final class AlmanacDevice
     PhabricatorDestructionEngine $engine) {
 
     $interfaces = id(new AlmanacInterfaceQuery())
-      ->setViewer(PhabricatorUser::getOmnipotentUser())
+      ->setViewer($engine->getViewer())
       ->withDevicePHIDs(array($this->getPHID()))
       ->execute();
     foreach ($interfaces as $interface) {

src/applications/almanac/storage/AlmanacInterface.php

@@ -119,7 +119,7 @@ final class AlmanacInterface
     PhabricatorDestructionEngine $engine) {
 
     $bindings = id(new AlmanacBindingQuery())
-      ->setViewer($this->getViewer())
+      ->setViewer($engine->getViewer())
       ->withInterfacePHIDs(array($this->getPHID()))
       ->execute();
     foreach ($bindings as $binding) {

src/applications/almanac/storage/AlmanacNetwork.php

@@ -103,7 +103,7 @@ final class AlmanacNetwork
     PhabricatorDestructionEngine $engine) {
 
     $interfaces = id(new AlmanacInterfaceQuery())
-      ->setViewer(PhabricatorUser::getOmnipotentUser())
+      ->setViewer($engine->getViewer())
       ->withNetworkPHIDs(array($this->getPHID()))
       ->execute();
 

src/applications/almanac/storage/AlmanacService.php

@@ -221,7 +221,7 @@ final class AlmanacService
     PhabricatorDestructionEngine $engine) {
 
     $bindings = id(new AlmanacBindingQuery())
-      ->setViewer(PhabricatorUser::getOmnipotentUser())
+      ->setViewer($engine->getViewer())
       ->withServicePHIDs(array($this->getPHID()))
       ->execute();
     foreach ($bindings as $binding) {

src/applications/differential/storage/DifferentialRevision.php

@@ -550,7 +550,7 @@ final class DifferentialRevision extends DifferentialDAO
 
     $this->openTransaction();
       $diffs = id(new DifferentialDiffQuery())
-        ->setViewer(PhabricatorUser::getOmnipotentUser())
+        ->setViewer($engine->getViewer())
         ->withRevisionIDs(array($this->getID()))
         ->execute();
       foreach ($diffs as $diff) {

src/applications/diviner/storage/DivinerLiveBook.php

@@ -91,7 +91,7 @@ final class DivinerLiveBook extends DivinerDAO
 
     $this->openTransaction();
       $atoms = id(new DivinerAtomQuery())
-        ->setViewer(PhabricatorUser::getOmnipotentUser())
+        ->setViewer($engine->getViewer())
         ->withBookPHIDs(array($this->getPHID()))
         ->withIncludeGhosts(true)
         ->withIncludeUndocumentable(true)

src/applications/files/controller/PhabricatorFileTransformController.php

@@ -104,8 +104,9 @@ final class PhabricatorFileTransformController
   }
 
   private function destroyTransform(PhabricatorTransformedFile $xform) {
+    $engine = new PhabricatorDestructionEngine();
     $file = id(new PhabricatorFileQuery())
-      ->setViewer(PhabricatorUser::getOmnipotentUser())
+      ->setViewer($engine->getViewer())
       ->withPHIDs(array($xform->getTransformedPHID()))
       ->executeOne();
 
@@ -114,7 +115,6 @@ final class PhabricatorFileTransformController
     if (!$file) {
       $xform->delete();
     } else {
-      $engine = new PhabricatorDestructionEngine();
       $engine->destroyObject($file);
     }
 

src/applications/files/storage/PhabricatorFileChunk.php

@@ -91,7 +91,7 @@ final class PhabricatorFileChunk extends PhabricatorFileDAO
     $data_phid = $this->getDataFilePHID();
     if ($data_phid) {
       $data_file = id(new PhabricatorFileQuery())
-        ->setViewer(PhabricatorUser::getOmnipotentUser())
+        ->setViewer($engine->getViewer())
         ->withPHIDs(array($data_phid))
         ->executeOne();
       if ($data_file) {

src/applications/paste/storage/PhabricatorPaste.php

@@ -172,7 +172,7 @@ final class PhabricatorPaste extends PhabricatorPasteDAO
 
     if ($this->filePHID) {
       $file = id(new PhabricatorFileQuery())
-        ->setViewer(PhabricatorUser::getOmnipotentUser())
+        ->setViewer($engine->getViewer())
         ->withPHIDs(array($this->filePHID))
         ->executeOne();
       if ($file) {

src/applications/system/engine/PhabricatorDestructionEngine.php

@@ -4,6 +4,10 @@ final class PhabricatorDestructionEngine extends Phobject {
 
   private $rootLogID;
 
+  public function getViewer() {
+    return PhabricatorUser::getOmnipotentUser();
+  }
+
   public function destroyObject(PhabricatorDestructibleInterface $object) {
     $log = id(new PhabricatorSystemDestructionLog())
       ->setEpoch(time())