From 3f3304fd614f58827d14b7995875df601757c603 Mon Sep 17 00:00:00 2001
From: grglr <grglr@fb.com>
Date: Thu, 28 Apr 2011 14:32:29 -0700
Subject: [PATCH] Differential whitespace mode IGNORE ALL now shows correct
 indentation

Summary:
Fixed buggy and incomplete logic for handling IGNORE ALL mode properly.
A subparser is used to parse the non-ws-ignoring changeset while a
ws-ignoring changeset is handed off to the original parser.  At a later
step, the original parser queries the subparser for its lines of text
(which are formatted properly due to being in non-ws-ignoring mode) and
uses them to replace the text in the ws-ignoring diff.

Task ID: 549940

Test Plan:
-turn off caching temporarily (the cached view is still indented
improperly)
-visit http://phabricator.dev1943.facebook.com/D242591
-note aligned, but not completely highlighted, indentation right above the
comments complaining about
indentation issues

Reviewed By: aran
Reviewers: tuomaspelkonen, jungejason, aran
Commenters: epriestley
CC: aran, epriestley, grglr
Differential Revision: 174
---
 .../changeset/DifferentialChangesetParser.php | 35 ++++++++++---------
 1 file changed, 18 insertions(+), 17 deletions(-)

diff --git a/src/applications/differential/parser/changeset/DifferentialChangesetParser.php b/src/applications/differential/parser/changeset/DifferentialChangesetParser.php
index f03c88ce79..f2641b32d0 100644
--- a/src/applications/differential/parser/changeset/DifferentialChangesetParser.php
+++ b/src/applications/differential/parser/changeset/DifferentialChangesetParser.php
@@ -141,7 +141,6 @@ class DifferentialChangesetParser {
 
     $types = array();
     foreach ($lines as $line_index => $line) {
-      $lines[$line_index] = $line;
       if (isset($line[0])) {
         $char = $line[0];
         if ($char == ' ') {
@@ -308,18 +307,17 @@ class DifferentialChangesetParser {
 
     $this->old = $old;
     $this->new = $new;
+    if ($this->subparser) {
 
-    if ($this->subparser && false) { // TODO: This is bugged
+      // Use this parser's side-by-side line information -- notably, the
+      // change types -- but replace all the line text with the subparser's.
+      // This lets us render whitespace-only changes without marking them as
+      // different.
 
-      // Use the subparser's side-by-side line information -- notably, the
-      // change types -- but replace all the line text with ours. This lets us
-      // render whitespace-only changes without marking them as different.
-
-      $old = $this->subparser->old;
-      $new = $this->subparser->new;
-
-      $old_text = ipull($this->old, 'text', 'line');
-      $new_text = ipull($this->new, 'text', 'line');
+      $old = $this->old;
+      $new = $this->new;
+      $old_text = ipull($this->subparser->old, 'text', 'line');
+      $new_text = ipull($this->subparser->new, 'text', 'line');
 
       foreach ($old as $k => $desc) {
         if (empty($desc)) {
@@ -406,7 +404,7 @@ class DifferentialChangesetParser {
     $this->tokenHighlight($this->newRender);
 
     $unchanged = false;
-    if ($this->subparser && false) {
+    if ($this->subparser) {
       $unchanged = $this->subparser->isUnchanged();
       $whitelines = $this->subparser->isWhitespaceOnly();
     } else if (!$changed) {
@@ -671,15 +669,18 @@ class DifferentialChangesetParser {
 EOSYNTHETIC;
           }
 
-          $changes = id(new ArcanistDiffParser())->parseDiff($diff);
+          // subparser takes over the current non-whitespace-ignoring changeset
+          $this->subparser = new DifferentialChangesetParser();
+          foreach ($changeset->getHunks() as $hunk) {
+            $this->subparser->parseHunk($hunk);
+          }
 
+          // this parser takes new changeset; will use subparser's text later
+          $changes = id(new ArcanistDiffParser())->parseDiff($diff);
           $diff = DifferentialDiff::newFromRawChanges($changes);
           $changesets = $diff->getChangesets();
           $changeset = reset($changesets);
-
-          $this->subparser = new DifferentialChangesetParser();
-          $this->subparser->setChangeset($changeset);
-          $this->subparser->setWhitespaceMode(self::WHITESPACE_IGNORE_TRAILING);
+          $this->setChangeset($changeset);
         }
         foreach ($changeset->getHunks() as $hunk) {
           $this->parseHunk($hunk);