Use PhabricatorObjectListQuery in Herald worker

Summary: Ref T2222. Straightforward, just breaks a needless dependency.

Test Plan: Pushed and parsed a commit with "Auditors" in it.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2222

Differential Revision: https://secure.phabricator.com/D8473

src/applications/repository/worker/PhabricatorRepositoryCommitHeraldWorker.php

@@ -270,10 +270,16 @@ final class PhabricatorRepositoryCommitHeraldWorker
       return array();
     }
 
-    $phids = DifferentialFieldSpecification::parseCommitMessageObjectList(
+    $phids = id(new PhabricatorObjectListQuery())
-      $matches[1],
+      ->setViewer(PhabricatorUser::getOmnipotentUser())
-      $include_mailables = false,
+      ->setAllowPartialResults(true)
-      $allow_partial = true);
+      ->setAllowedTypes(
+        array(
+          PhabricatorPeoplePHIDTypeUser::TYPECONST,
+          PhabricatorProjectPHIDTypeProject::TYPECONST,
+        ))
+      ->setObjectList($matches[1])
+      ->execute();
 
     if (!$phids) {
       return array();