mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-19 03:50:54 +01:00
Convert Create/Edit Column pages to dialogs
Summary: Makes these pages a dialog endpoint, keeping you on the Workboard when possible. Test Plan: Create a Column, Edit a Column, visit hard page. Test letters in the points field. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15270
This commit is contained in:
parent
c1f57605ab
commit
3fdaf229a7
2 changed files with 8 additions and 16 deletions
|
@ -692,7 +692,7 @@ final class PhabricatorProjectBoardViewController
|
|||
->setName(pht('Add Column'))
|
||||
->setHref($add_uri)
|
||||
->setDisabled(!$can_edit)
|
||||
->setWorkflow(!$can_edit);
|
||||
->setWorkflow(true);
|
||||
|
||||
$manage_items[] = id(new PhabricatorActionView())
|
||||
->setIcon('fa-exchange')
|
||||
|
|
|
@ -136,21 +136,13 @@ final class PhabricatorProjectColumnEditController
|
|||
$submit = pht('Save Column');
|
||||
}
|
||||
|
||||
$form->appendChild(
|
||||
id(new AphrontFormSubmitControl())
|
||||
->setValue($submit)
|
||||
->addCancelButton($view_uri));
|
||||
|
||||
$form_box = id(new PHUIObjectBoxView())
|
||||
->setHeaderText($title)
|
||||
->setValidationException($validation_exception)
|
||||
->setForm($form);
|
||||
|
||||
$nav = $this->getProfileMenu();
|
||||
|
||||
return $this->newPage()
|
||||
return $this->newDialog()
|
||||
->setWidth(AphrontDialogView::WIDTH_FORM)
|
||||
->setTitle($title)
|
||||
->setNavigation($nav)
|
||||
->appendChild($form_box);
|
||||
->appendForm($form)
|
||||
->setValidationException($validation_exception)
|
||||
->addCancelButton($view_uri)
|
||||
->addSubmitButton($submit);
|
||||
|
||||
}
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue