revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-29 10:12:41 +01:00
Code Issues Releases Wiki Activity

Remove the caret dropdown from transaction lists when no actions are available

Browse source 
Summary:
See PHI325. When a transaction group in Differential (or Pholio) only has an inline comment, it renders with a "V" caret but no actual dropdown menu.

This caret renders in a "disabled" color, but the color is "kinda grey". The "active" color is "kinda grey with a dab of blue". Here's what they look like today:

{F5401581}

Just remove it.

Test Plan: Viewed one of these, no longer saw the inactive caret.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D18963
This commit is contained in:
epriestley 2018-01-29 12:54:04 -08:00
parent d8f51dff6e
commit 40e9806e3c
3 changed files with 6 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
resources/celerity/map.php
View file

@ -9,7 +9,7 @@ return array(
'names' => array( 'names' => array(
'conpherence.pkg.css' => 'e68cf1fa', 'conpherence.pkg.css' => 'e68cf1fa',
'conpherence.pkg.js' => '15191c65', 'conpherence.pkg.js' => '15191c65',
'core.pkg.css' => '075f9867', 'core.pkg.css' => '51debec3',
'core.pkg.js' => '4c79d74f', 'core.pkg.js' => '4c79d74f',
'darkconsole.pkg.js' => '1f9a31bc', 'darkconsole.pkg.js' => '1f9a31bc',
'differential.pkg.css' => '45951e9e', 'differential.pkg.css' => '45951e9e',
@ -176,7 +176,7 @@ return array(
'rsrc/css/phui/phui-spacing.css' => '042804d6', 'rsrc/css/phui/phui-spacing.css' => '042804d6',
'rsrc/css/phui/phui-status.css' => 'd5263e49', 'rsrc/css/phui/phui-status.css' => 'd5263e49',
'rsrc/css/phui/phui-tag-view.css' => 'b4719c50', 'rsrc/css/phui/phui-tag-view.css' => 'b4719c50',
'rsrc/css/phui/phui-timeline-view.css' => 'e2ef62b1', 'rsrc/css/phui/phui-timeline-view.css' => '6ddf8126',
'rsrc/css/phui/phui-two-column-view.css' => '44ec4951', 'rsrc/css/phui/phui-two-column-view.css' => '44ec4951',
'rsrc/css/phui/workboards/phui-workboard-color.css' => '783cdff5', 'rsrc/css/phui/workboards/phui-workboard-color.css' => '783cdff5',
'rsrc/css/phui/workboards/phui-workboard.css' => '3bc85455', 'rsrc/css/phui/workboards/phui-workboard.css' => '3bc85455',
@ -873,7 +873,7 @@ return array(
'phui-status-list-view-css' => 'd5263e49', 'phui-status-list-view-css' => 'd5263e49',
'phui-tag-view-css' => 'b4719c50', 'phui-tag-view-css' => 'b4719c50',
'phui-theme-css' => '9f261c6b', 'phui-theme-css' => '9f261c6b',
'phui-timeline-view-css' => 'e2ef62b1', 'phui-timeline-view-css' => '6ddf8126',
'phui-two-column-view-css' => '44ec4951', 'phui-two-column-view-css' => '44ec4951',
'phui-workboard-color-css' => '783cdff5', 'phui-workboard-color-css' => '783cdff5',
'phui-workboard-view-css' => '3bc85455', 'phui-workboard-view-css' => '3bc85455',

8
src/view/phui/PHUITimelineEventView.php
View file

@ -301,18 +301,14 @@ final class PHUITimelineEventView extends AphrontView {
$menu = null; $menu = null;
$items = array(); $items = array();
$has_menu = false;
if (!$this->getIsPreview() && !$this->getHideCommentOptions()) { if (!$this->getIsPreview() && !$this->getHideCommentOptions()) {
foreach ($this->getEventGroup() as $event) { foreach ($this->getEventGroup() as $event) {
$items[] = $event->getMenuItems($this->anchor); $items[] = $event->getMenuItems($this->anchor);
if ($event->hasChildren()) {
$has_menu = true;
}
} }
$items = array_mergev($items); $items = array_mergev($items);
} }
if ($items || $has_menu) { if ($items) {
$icon = id(new PHUIIconView()) $icon = id(new PHUIIconView())
->setIcon('fa-caret-down'); ->setIcon('fa-caret-down');
$aural = javelin_tag( $aural = javelin_tag(
@ -351,6 +347,8 @@ final class PHUITimelineEventView extends AphrontView {
)); ));
$has_menu = true; $has_menu = true;
} else {
$has_menu = false;
} }
// Render "extra" information (timestamp, etc). // Render "extra" information (timestamp, etc).

4
webroot/rsrc/css/phui/phui-timeline-view.css
View file

@ -390,10 +390,6 @@
outline: none; outline: none;
} }
.phui-timeline-menu .phui-icon-view {
color: {$lightgreytext};
}
a.phui-timeline-menu .phui-icon-view { a.phui-timeline-menu .phui-icon-view {
color: {$bluetext}; color: {$bluetext};
} }