revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-25 06:50:55 +01:00
Code Issues Releases Wiki Activity

Mark renderActionDescription as abstract

Browse source 
Summary:
I got caught by this... my custom Herald action doesn't implement this method and now I am hitting this exception:

```
Call to undefined method HeraldHipChatNotificationAction::renderActionDescription()

/usr/src/phabricator/src/applications/herald/adapter/HeraldAdapter.php:896
```

Test Plan: N/A

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D13779
This commit is contained in:
Joshua Spence 2015-08-04 08:26:17 +10:00
parent 5f76c71d78
commit 4139305f73
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/herald/action/HeraldAction.php
View file

@ -23,6 +23,8 @@ abstract class HeraldAction extends Phobject {
abstract public function supportsRuleType($rule_type); abstract public function supportsRuleType($rule_type);
abstract public function applyEffect($object, HeraldEffect $effect); abstract public function applyEffect($object, HeraldEffect $effect);
abstract public function renderActionDescription($value);
protected function renderActionEffectDescription($type, $data) { protected function renderActionEffectDescription($type, $data) {
return null; return null;
} }