revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-15 18:10:53 +01:00
Code Issues Releases Wiki Activity

(stable) Stop populating or updating working copies in observed Mercurial repositories

Browse source 
Summary:
Ref T12961. Fixes T4416. Currently, for observed Mercurial repositories, we build a working copy with `pull -u` (for "update").

This should be unnecessary, and we don't do it for hosted Mercurial repositories. We also stopped doing it years ago for Git repositories. We also don't clone Mercurial repositories with a working copy.

It's possible something has slipped through the cracks here so I'll hold this until after the release cut, but I believe there are no actual technical blockers here.

Test Plan:
  - Observed a public Mercurial repository on Bitbucket.
  - Let it import.
  - Browsed commits, branches, file content, etc., without any apparent issues.

Reviewers: chad

Reviewed By: chad

Subscribers: cspeckmim

Maniphest Tasks: T12961, T4416

Differential Revision: https://secure.phabricator.com/D18390
This commit is contained in:
epriestley 2017-08-10 17:22:32 -07:00
parent 77e4e6fdb4
commit 41e823796a
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/repository/engine/PhabricatorRepositoryPullEngine.php
View file

@ -529,7 +529,7 @@ final class PhabricatorRepositoryPullEngine
// This is a local command, but needs credentials. // This is a local command, but needs credentials.
$remote = $repository->getRemoteURIEnvelope(); $remote = $repository->getRemoteURIEnvelope();
$future = $repository->getRemoteCommandFuture('pull -u -- %P', $remote); $future = $repository->getRemoteCommandFuture('pull -- %P', $remote);
$future->setCWD($path); $future->setCWD($path);
try { try {