From 41ea204144ab18512906f947949608dff2a48e8e Mon Sep 17 00:00:00 2001 From: epriestley Date: Thu, 11 Jul 2019 15:47:53 -0700 Subject: [PATCH] Update one straggling "CAN_INTERACT" check in comment removal Summary: See rPaacc62463d61. D20551 added some `CAN_INTERACT` checks, but `CAN_INTERACT` needs to be checked with `canInteract()` to fall back to `CAN_VIEW` properly. D20558 cleaned up most of this but missed one callsite; fix that up too. Test Plan: Removed a comment on a commit. Reviewers: amckinley, 20after4 Reviewed By: amckinley Differential Revision: https://secure.phabricator.com/D20648 --- ...bricatorApplicationTransactionCommentRemoveController.php | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/applications/transactions/controller/PhabricatorApplicationTransactionCommentRemoveController.php b/src/applications/transactions/controller/PhabricatorApplicationTransactionCommentRemoveController.php index f81535e4ae..4d6570b13d 100644 --- a/src/applications/transactions/controller/PhabricatorApplicationTransactionCommentRemoveController.php +++ b/src/applications/transactions/controller/PhabricatorApplicationTransactionCommentRemoveController.php @@ -38,10 +38,9 @@ final class PhabricatorApplicationTransactionCommentRemoveController // from locked threads. $object = $xaction->getObject(); - $can_interact = PhabricatorPolicyFilter::hasCapability( + $can_interact = PhabricatorPolicyFilter::canInteract( $viewer, - $object, - PhabricatorPolicyCapability::CAN_INTERACT); + $object); if (!$can_interact && !$viewer->getIsAdmin()) { return $this->newDialog() ->setTitle(pht('Conversation Locked'))