From 42020e135767583d001452de1b170686262d90dd Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Fri, 11 Aug 2017 09:33:24 -0700
Subject: [PATCH] Completely remove "differential.find" Conduit API method

Summary:
Ref T2543. I believe there have been no upstream callsites of this method since D1646, in February 2012.

The method works, and we can revert this if needbe, but this seems like a good time to remove support.

Test Plan: Grepped for `differential.find`.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T2543

Differential Revision: https://secure.phabricator.com/D18397
---
 src/__phutil_library_map__.php                |  2 -
 .../DifferentialFindConduitAPIMethod.php      | 99 -------------------
 2 files changed, 101 deletions(-)
 delete mode 100644 src/applications/differential/conduit/DifferentialFindConduitAPIMethod.php

diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php
index 703962b2ae..40a38b732c 100644
--- a/src/__phutil_library_map__.php
+++ b/src/__phutil_library_map__.php
@@ -445,7 +445,6 @@ phutil_register_library_map(array(
     'DifferentialExactUserFunctionDatasource' => 'applications/differential/typeahead/DifferentialExactUserFunctionDatasource.php',
     'DifferentialFieldParseException' => 'applications/differential/exception/DifferentialFieldParseException.php',
     'DifferentialFieldValidationException' => 'applications/differential/exception/DifferentialFieldValidationException.php',
-    'DifferentialFindConduitAPIMethod' => 'applications/differential/conduit/DifferentialFindConduitAPIMethod.php',
     'DifferentialGetAllDiffsConduitAPIMethod' => 'applications/differential/conduit/DifferentialGetAllDiffsConduitAPIMethod.php',
     'DifferentialGetCommitMessageConduitAPIMethod' => 'applications/differential/conduit/DifferentialGetCommitMessageConduitAPIMethod.php',
     'DifferentialGetCommitPathsConduitAPIMethod' => 'applications/differential/conduit/DifferentialGetCommitPathsConduitAPIMethod.php',
@@ -5419,7 +5418,6 @@ phutil_register_library_map(array(
     'DifferentialExactUserFunctionDatasource' => 'PhabricatorTypeaheadCompositeDatasource',
     'DifferentialFieldParseException' => 'Exception',
     'DifferentialFieldValidationException' => 'Exception',
-    'DifferentialFindConduitAPIMethod' => 'DifferentialConduitAPIMethod',
     'DifferentialGetAllDiffsConduitAPIMethod' => 'DifferentialConduitAPIMethod',
     'DifferentialGetCommitMessageConduitAPIMethod' => 'DifferentialConduitAPIMethod',
     'DifferentialGetCommitPathsConduitAPIMethod' => 'DifferentialConduitAPIMethod',
diff --git a/src/applications/differential/conduit/DifferentialFindConduitAPIMethod.php b/src/applications/differential/conduit/DifferentialFindConduitAPIMethod.php
deleted file mode 100644
index 8a8b8c8198..0000000000
--- a/src/applications/differential/conduit/DifferentialFindConduitAPIMethod.php
+++ /dev/null
@@ -1,99 +0,0 @@
-<?php
-
-final class DifferentialFindConduitAPIMethod
-  extends DifferentialConduitAPIMethod {
-
-  public function getAPIMethodName() {
-    return 'differential.find';
-  }
-
-  public function getMethodStatus() {
-    return self::METHOD_STATUS_DEPRECATED;
-  }
-
-  public function getMethodStatusDescription() {
-    return pht("Replaced by '%s'.", 'differential.query');
-  }
-
-  public function getMethodDescription() {
-    return pht('Query Differential revisions which match certain criteria.');
-  }
-
-  protected function defineParamTypes() {
-    $types = array(
-      'open',
-      'committable',
-      'revision-ids',
-      'phids',
-    );
-
-    return array(
-      'query' => 'required '.$this->formatStringConstants($types),
-      'guids' => 'required nonempty list<guids>',
-    );
-  }
-
-  protected function defineReturnType() {
-    return 'nonempty list<dict>';
-  }
-
-  protected function execute(ConduitAPIRequest $request) {
-    $type = $request->getValue('query');
-    $guids = $request->getValue('guids');
-
-    $results = array();
-    if (!$guids) {
-      return $results;
-    }
-
-    $query = id(new DifferentialRevisionQuery())
-      ->setViewer($request->getUser());
-
-    switch ($type) {
-      case 'open':
-        $query
-          ->withIsOpen(true)
-          ->withAuthors($guids);
-        break;
-      case 'committable':
-        $query
-          ->withStatuses(DifferentialRevisionStatus::ACCEPTED)
-          ->withAuthors($guids);
-        break;
-      case 'revision-ids':
-        $query
-          ->withIDs($guids);
-        break;
-      case 'owned':
-        $query->withAuthors($guids);
-        break;
-      case 'phids':
-        $query
-          ->withPHIDs($guids);
-        break;
-    }
-
-    $revisions = $query->execute();
-
-    foreach ($revisions as $revision) {
-      $diff = $revision->loadActiveDiff();
-      if (!$diff) {
-        continue;
-      }
-      $id = $revision->getID();
-      $results[] = array(
-        'id'          => $id,
-        'phid'        => $revision->getPHID(),
-        'name'        => $revision->getTitle(),
-        'uri'         => PhabricatorEnv::getProductionURI('/D'.$id),
-        'dateCreated' => $revision->getDateCreated(),
-        'authorPHID'  => $revision->getAuthorPHID(),
-        'statusName'  => $revision->getStatusDisplayName(),
-        'sourcePath'  => $diff->getSourcePath(),
-      );
-    }
-
-    return $results;
-  }
-
-}