revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-10 14:51:06 +01:00
Code Issues Releases Wiki Activity

Correct the generation of "<th />" IDs on left-hand-side of image changesets

Browse source 
Summary:
Fixes T7682. The left-hand-side "<th />" row did not generate with the correct ID.

(I couldn't reproduce the exact issue described in T7682, but hovering comments on either side now works properly for me.)

Test Plan: {F4962479}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T7682

Differential Revision: https://secure.phabricator.com/D17926
This commit is contained in:
epriestley 2017-05-17 05:52:45 -07:00
parent e4e91ebf6f
commit 422eb9db83
1 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php
View file

@ -323,6 +323,12 @@ final class DifferentialChangesetTwoUpRenderer
$new = $this->renderImageStage($new_file); $new = $this->renderImageStage($new_file);
} }
// If we don't have an explicit "vs" changeset, it's the left side of the
// "id" changeset.
if (!$vs) {
$vs = $id;
}
$html_old = array(); $html_old = array();
$html_new = array(); $html_new = array();
foreach ($this->getOldComments() as $on_line => $comment_group) { foreach ($this->getOldComments() as $on_line => $comment_group) {