revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-22 13:30:55 +01:00
Code Issues Releases Wiki Activity

Fix an issue which could prevent blocking reviewers from being removed from revisions

Browse source 
Summary: Ref T11114. After evaluating typeahead tokens, we could process blocking reviewer removals incorrectly: we may get structures back.

Test Plan: Removed blocking reviewers from the web UI.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11114

Differential Revision: https://secure.phabricator.com/D17163
This commit is contained in:
epriestley 2017-01-09 08:00:07 -08:00
parent aa6e788f36
commit 425deeb523
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/applications/differential/xaction/DifferentialRevisionReviewersTransaction.php
View file

@ -24,7 +24,13 @@ final class DifferentialRevisionReviewersTransaction
// First, remove any reviewers we're getting rid of. // First, remove any reviewers we're getting rid of.
$rem = idx($value, '-', array()); $rem = idx($value, '-', array());
$rem = $datasource->evaluateTokens($rem); $rem = $datasource->evaluateTokens($rem);
foreach ($rem as $phid) { foreach ($rem as $spec) {
if (!is_array($spec)) {
$phid = $spec;
} else {
$phid = $spec['phid'];
}
unset($reviewers[$phid]); unset($reviewers[$phid]);
} }