From 4277123060764d78ff1b282413857e17ba7acc3b Mon Sep 17 00:00:00 2001 From: James Rhodes Date: Thu, 25 Sep 2014 09:46:47 +1000 Subject: [PATCH] Increase Drydock worker time to 24 hours Summary: Ref T2015. This increases the Drydock worker lease time to 24 hours. We noticed that some leases took longer than 2 hours when leasing from AWS (the actual resource was successfully leased at around 2 hours, 19 minutes). 24 hours should be plenty enough time to actually lease anything from EC2 (or any other leases during builds). Test Plan: Have not yet tested this. Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T2015 Differential Revision: https://secure.phabricator.com/D10544 --- src/applications/drydock/worker/DrydockAllocatorWorker.php | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/applications/drydock/worker/DrydockAllocatorWorker.php b/src/applications/drydock/worker/DrydockAllocatorWorker.php index 3b955f16fe..6d8e740e18 100644 --- a/src/applications/drydock/worker/DrydockAllocatorWorker.php +++ b/src/applications/drydock/worker/DrydockAllocatorWorker.php @@ -4,6 +4,10 @@ final class DrydockAllocatorWorker extends PhabricatorWorker { private $lease; + public function getRequiredLeaseTime() { + return 3600 * 24; + } + public function getMaximumRetryCount() { // TODO: Allow Drydock allocations to retry. For now, every failure is // permanent and most of them are because I am bad at programming, so fail